Merged
Conversation
The main build broke after e783bf5 due to two issues: 1. sessionv2_integration_test.go referenced MetadataKeyTokenSalt without the sessiontypes package prefix, causing a typecheck error that failed lint and cascaded into test compilation failures for dependent packages. 2. TestMiddleware_ContextTimeoutHandling hard-coded a 15-second wait for the discovery timeout constant. Make discoveryTimeout injectable via WithDiscoveryTimeout middleware option so the test uses 100ms instead, cutting the test from 15s to 0.1s. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
amirejaz
approved these changes
Mar 10, 2026
Contributor
|
@copilot review this PR if test time can further be reduced |
3 tasks
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4071 +/- ##
==========================================
- Coverage 68.67% 68.55% -0.13%
==========================================
Files 446 446
Lines 45433 45547 +114
==========================================
+ Hits 31203 31223 +20
- Misses 11818 11913 +95
+ Partials 2412 2411 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ChrisJBurns
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MetadataKeyTokenSaltinsessionv2_integration_test.go, causing a typecheck lint failure that cascaded into test compilation failures for dependent packages.TestMiddleware_ContextTimeoutHandlinghard-coded a 15-second wait for thediscoveryTimeoutconstant, making it slow and fragile. Made the timeout injectable viaWithDiscoveryTimeoutmiddleware option so the test uses 100ms instead.Type of change
Test plan
task test)task lint-fix)Does this introduce a user-facing change?
No
Generated with Claude Code