Conversation
The main build broke after e783bf5 due to two issues: 1. sessionv2_integration_test.go referenced MetadataKeyTokenSalt without the sessiontypes package prefix, causing a typecheck error that failed lint and cascaded into test compilation failures for dependent packages. 2. TestMiddleware_ContextTimeoutHandling hard-coded a 15-second wait for the discovery timeout constant. Make discoveryTimeout injectable via WithDiscoveryTimeout middleware option so the test uses 100ms instead, cutting the test from 15s to 0.1s. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
Co-authored-by: amirejaz <195902446+amirejaz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CI build failures on main
Fix CI build failures on main
Mar 10, 2026
Member
|
Hey, @amirejaz, closing this one as I think the issue is already fixed (feel free to reopen of course). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two CI failures after e783bf5 ("Automate HMAC secret management"):
sessionv2_integration_test.goreferencedMetadataKeyTokenSaltwithout itssessiontypespackage prefix → typecheck lint failure cascading into test compilation failures for dependent packages.TestMiddleware_ContextTimeoutHandlinghard-coded a 15s wait on thediscoveryTimeoutconstant → slow, fragile test.Changes:
sessiontypes.prefix onMetadataKeyTokenSaltdiscoveryTimeoutinjectable viaWithDiscoveryTimeoutmiddleware optiontestTimeoutfrom 100ms → 10ms (test now completes in ~0.01s vs original 15s); shrink unreachable safety-nettime.Afterfrom 5s → 1sType of change
Test plan
task test)task lint-fix)Does this introduce a user-facing change?
No
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.