Do not drop inputs and intermediates in empty dataset transform_coords
#3274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Of what? |
Member
|
That coords are kept for empty datasets. |
Member
Author
There was an existing test for this, and I had to modify it, see diff? |
jl-wynen
approved these changes
Oct 5, 2023
Member
|
Oh, I missed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3156.
My comment in the linked issue actually overlooked that removing
attrsis not enough to simplify the code, since we may still have binned data in dataset items, each with their own coords. Therefore, the core aspect cannot be simplified.I found this minor leftover from the pre-alignment-flag implementation, which I fix here, making behavior of
transform_coordsconsistent betweenDataArrayandDataset, even in the "empty" case.