ci: match Rustls style, add cargo-semver-checks, dependabot#118
Merged
cpu merged 9 commits intorustls:mainfrom Jul 14, 2023
Merged
ci: match Rustls style, add cargo-semver-checks, dependabot#118cpu merged 9 commits intorustls:mainfrom
cpu merged 9 commits intorustls:mainfrom
Conversation
Member
Author
I'll need to fix up the branch protection rules - the name changes have thrown them off. |
ctz
approved these changes
Jul 14, 2023
This commit moves around some whitespace to match the convention the `rustls/rustls` CI repo uses.
This commit reorders the `on` triggers to match the rustls repo, and ads a `cron` scheduled run to ensure we catch bitrot early even if the repo isn't seeing active development.
In our other repos we tend to use the checkout action step first, and then the other steps. We can also avoid the YAML multi-line scalar stuff for simple lines.
In the rustls repo we tend to 'name' tasks. This commit applies the same convention/choice of names here.
* Add a cron schedule. * Consistent whitespace.
This commit adds a dependabot config matching the main rustls repo.
This commit updates the `build.yml` GitHub actions workflow to additionally include a step that checks semver compatibility w/ cargo-semver-checks[0]. Notably this check passing is necessary but not sufficient for knowing that we're maintaining semver: if this tool produces a finding we know we aren't matching semver, but if it doesn't, we may still be breaking semver in a way the tool can't detect. [0]: https://github.com/obi1kenobi/cargo-semver-checks
Codecov Report
@@ Coverage Diff @@
## main #118 +/- ##
=======================================
Coverage 95.69% 95.69%
=======================================
Files 15 15
Lines 3346 3346
=======================================
Hits 3202 3202
Misses 144 144 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
Author
Member
Author
|
Branch protection rules updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #115 it was pointed out that the webpki CI wasn't very consistent with the Rustls repo. In particular the whitespace style differed, and steps weren't being annotated with
names.This branch does a quick standardization pass, and also adds a new
cargo-semver-checkstep, tightens up thecargo docstep to forbid warnings, adds a cron schedule, and adds a dependabot config.Probably easiest to review commit-by-commit.