Merged
Conversation
* Use stable rust. * Use taiki-e/install-action to get cross.
Codecov Report
@@ Coverage Diff @@
## main #115 +/- ##
=======================================
Coverage 95.36% 95.36%
=======================================
Files 15 15
Lines 3346 3346
=======================================
Hits 3191 3191
Misses 155 155 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
complexspaces
approved these changes
Jul 6, 2023
djc
approved these changes
Jul 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick follow-up to #113 now that the fire is out.
taiki-e/install-actionto getcross. In fix 32 bit support, add i686-unknown-linux-gnu CI target #113 I was worried about introducing new 3rd party actions into the workflows but we're already relying on this 3rd party action to installcargo llvm-covandcargo denyand it has support for gettingcrossthe same way.cargo install crossthat were temporarily resolved by using nightly, but this isn't necessary now that we're using theinstall-action.This should reduce the additional build time that was introduced with #113 while still maintaining the cross compilation test.