fix(virtual): prepare for Rollup 3#1280
Merged
lukastaegert merged 1 commit intomasterfrom Oct 10, 2022
Merged
Conversation
19a7c16 to
96e6121
Compare
BREAKING CHANGES: Requires Node 14
96e6121 to
6a295c5
Compare
Collaborator
|
PLEASE HOLD UP. THERE ARE BREAKING CHANGES IN THE REPO. PLEASE CHECK COMMENTS AND DISCORS |
Member
Author
|
I actually need to merge the remaining PRs to resolve these |
Collaborator
|
in the future please coordinate so that we can knock out all of those changes at once - that's doable given the changes being made. anybody who opens up a PR right now is going to have a bad day. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
virtualThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
This PR updates the plugin for Rollup 3 compatibility. This will not change compatibility with older Rollup versions.
It contains the following:
||^3.0.0This allows to share bundling improvements and unifies the build
All plugins now use
strictDeprecationsto fail early if they use deprecated Rollup features as well as anonwardhandler that fails the buildThe CJS output now uses
which will allow the default export to be directly required while still supporting named exports
"exports"package.jsonfield is now properly configured forrequireandimport.package.jsonfile with"type": "module"next to the CJS output (via the shared Rollup config).mjsfor ESM configs, no direct import ofpackage.json