fix(inject): rollup is optional peer dependency#1272
Closed
milahu wants to merge 1 commit intorollup:masterfrom
Closed
fix(inject): rollup is optional peer dependency#1272milahu wants to merge 1 commit intorollup:masterfrom
milahu wants to merge 1 commit intorollup:masterfrom
Conversation
This was referenced Sep 30, 2022
lukastaegert
approved these changes
Oct 1, 2022
Member
There was a problem hiding this comment.
Thanks a lot! Considering your arguments, I added this change to all PRs I just created for Rollup 3 compatibility of plugins, see e.g. #1292. This supersedes your PR, but we can still merge it first if you want the contribution.
Author
|
thanks : )
i dont care |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
injectThis PR contains:
Are tests included?
Breaking Changes?
Relevant issues:
Description
this plugin can be used from vite
for example in https://github.com/sodatea/vite-plugin-node-stdlib-browser
in this case, rollup is not installed
this fix should also be applied to other rollup plugins
workaround for pnpm: add this to
package.json{ "pnpm": { "peerDependencyRules": { "ignoreMissing": [ "rollup" ] } } }