Skip to content

feat: align generated chunk name with rollup#2124

Merged
hyf0 merged 2 commits intomainfrom
09-02-feat_align_generated_chunk_name_with_rollup
Sep 2, 2024
Merged

feat: align generated chunk name with rollup#2124
hyf0 merged 2 commits intomainfrom
09-02-feat_align_generated_chunk_name_with_rollup

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Sep 2, 2024

Description

@hyf0 hyf0 marked this pull request as ready for review September 2, 2024 12:34
@hyf0 Graphite App
Copy link
Member Author

hyf0 commented Sep 2, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

@hyf0 hyf0 mentioned this pull request Sep 2, 2024
Merged
Base automatically changed from 09-02-fix_should_also_care_for_chunk_name_for_common_chunks to main September 2, 2024 12:51
@hyf0 hyf0 force-pushed the 09-02-feat_align_generated_chunk_name_with_rollup branch from 420a42e to e414ad5 Compare September 2, 2024 12:51
@hyf0 Graphite App
Copy link
Member Author

hyf0 commented Sep 2, 2024

Merge activity

  • Sep 2, 8:52 AM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@netlify
Copy link

netlify bot commented Sep 2, 2024

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit e414ad5
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66d5b4dbd9b20300085f9852

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

Benchmarks Rust

  • target: main(a1fa701)
  • pr: 09-02-feat_align_generated_chunk_name_with_rollup(e414ad5)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.01     52.8±0.76ms        ? ?/sec    1.00     52.0±0.93ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.02     78.5±1.20ms        ? ?/sec    1.00     76.9±1.20ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.03     95.2±1.01ms        ? ?/sec    1.00     92.6±1.06ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     61.3±0.65ms        ? ?/sec    1.01     61.8±2.26ms        ? ?/sec
bundle/bundle@rome-ts                                               1.01    101.6±0.93ms        ? ?/sec    1.00    101.0±1.05ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.01    185.1±3.28ms        ? ?/sec    1.00    182.9±4.73ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    228.6±7.27ms        ? ?/sec    1.00    228.5±4.86ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    116.7±1.34ms        ? ?/sec    1.00    116.8±1.16ms        ? ?/sec
bundle/bundle@threejs                                               1.05     33.6±1.06ms        ? ?/sec    1.00     31.9±0.20ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.02     78.8±1.27ms        ? ?/sec    1.00     77.2±1.59ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.02     98.5±2.37ms        ? ?/sec    1.00     96.5±1.74ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.04     42.8±1.18ms        ? ?/sec    1.00     41.2±0.37ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    354.0±3.22ms        ? ?/sec    1.00    353.1±3.23ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.01    957.2±6.84ms        ? ?/sec    1.00    948.6±8.23ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.01  1218.7±10.39ms        ? ?/sec    1.00   1207.8±9.38ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.02    421.8±2.73ms        ? ?/sec    1.00    415.5±2.77ms        ? ?/sec
remapping/remapping                                                 1.00     31.3±0.13ms        ? ?/sec    1.07     33.6±0.35ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     85.5±0.53ms        ? ?/sec    1.00     85.4±0.28ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     81.7±0.94ms        ? ?/sec    1.00     81.5±0.79ms        ? ?/sec
scan/scan@threejs                                                   1.00     24.9±0.29ms        ? ?/sec    1.01     25.3±2.28ms        ? ?/sec
scan/scan@threejs10x                                                1.00    249.9±2.20ms        ? ?/sec    1.02    253.7±2.83ms        ? ?/sec

@hyf0 hyf0 added this pull request to the merge queue Sep 2, 2024
Merged via the queue into main with commit 0bec3bc Sep 2, 2024
@hyf0 hyf0 deleted the 09-02-feat_align_generated_chunk_name_with_rollup branch September 2, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyf0 @IWANABETHATGUY