Skip to content

fix: should also care for Chunk#name for common chunks#2123

Merged
hyf0 merged 1 commit intomainfrom
09-02-fix_should_also_care_for_chunk_name_for_common_chunks
Sep 2, 2024
Merged

fix: should also care for Chunk#name for common chunks#2123
hyf0 merged 1 commit intomainfrom
09-02-fix_should_also_care_for_chunk_name_for_common_chunks

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented Sep 2, 2024

Description

@hyf0 hyf0 marked this pull request as ready for review September 2, 2024 12:34
@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Sep 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

@hyf0 hyf0 mentioned this pull request Sep 2, 2024
Merged
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 2, 2024

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 4726c6c
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66d5b0c61bafa20008f63175

@hyf0 hyf0 added this pull request to the merge queue Sep 2, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 2, 2024

Benchmarks Rust

  • target: main(ea76b06)
  • pr: 09-02-fix_should_also_care_for_chunk_name_for_common_chunks(4726c6c)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.01     54.0±0.63ms        ? ?/sec    1.00     53.3±1.25ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.07     80.4±1.96ms        ? ?/sec    1.00     74.9±1.13ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.04     96.0±1.35ms        ? ?/sec    1.00     92.5±1.08ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.01     63.2±1.07ms        ? ?/sec    1.00     62.7±1.56ms        ? ?/sec
bundle/bundle@rome-ts                                               1.03    104.4±1.34ms        ? ?/sec    1.00    101.5±1.05ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    180.8±3.25ms        ? ?/sec    1.02    183.6±2.47ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.01    231.9±3.69ms        ? ?/sec    1.00    228.6±3.01ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.01    119.2±1.46ms        ? ?/sec    1.00    117.6±1.43ms        ? ?/sec
bundle/bundle@threejs                                               1.00     32.1±0.89ms        ? ?/sec    1.00     32.1±0.39ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     78.4±1.71ms        ? ?/sec    1.00     78.5±1.15ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00     98.0±0.96ms        ? ?/sec    1.01     98.8±1.58ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     41.0±0.30ms        ? ?/sec    1.02     41.8±0.28ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    351.7±6.46ms        ? ?/sec    1.01    354.0±4.48ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   968.2±11.76ms        ? ?/sec    1.01   973.3±10.94ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1231.4±18.14ms        ? ?/sec    1.00  1231.2±11.42ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    421.8±4.19ms        ? ?/sec    1.01    427.9±5.36ms        ? ?/sec
remapping/remapping                                                 1.00     33.8±0.37ms        ? ?/sec    1.00     33.9±0.39ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     86.0±0.40ms        ? ?/sec    1.01     86.9±0.78ms        ? ?/sec
scan/scan@rome-ts                                                   1.01     82.2±0.78ms        ? ?/sec    1.00     81.7±0.81ms        ? ?/sec
scan/scan@threejs                                                   1.00     24.9±0.80ms        ? ?/sec    1.00     25.0±1.52ms        ? ?/sec
scan/scan@threejs10x                                                1.01    252.2±2.13ms        ? ?/sec    1.00    250.4±2.40ms        ? ?/sec

Merged via the queue into main with commit a1fa701 Sep 2, 2024
@hyf0 hyf0 deleted the 09-02-fix_should_also_care_for_chunk_name_for_common_chunks branch September 2, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyf0 @IWANABETHATGUY