Skip to content

fix: collect-dependends-symbol#2079

Merged
IWANABETHATGUY merged 6 commits intomainfrom
fix/collect-dependends-symbol
Aug 28, 2024
Merged

fix: collect-dependends-symbol#2079
IWANABETHATGUY merged 6 commits intomainfrom
fix/collect-dependends-symbol

Conversation

@IWANABETHATGUY
Copy link
Copy Markdown
Member

@IWANABETHATGUY IWANABETHATGUY commented Aug 27, 2024 •
edited
Loading

Description

  1. Closed [Bug]: thread '<unnamed>' panicked at crates/rolldown/src/types/symbols.rs:68:7: #2038
  2. in main branch the testcase will panic.
thread '<unnamed>' panicked at crates/rolldown/src/types/symbols.rs:68:7:
canonical name not found for SymbolRef { owner: 3, symbol: SymbolId(0) }, original_name: "result"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

@IWANABETHATGUY IWANABETHATGUY changed the title chore: 🤖 update fix: collect-dependends-symbol Aug 27, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Aug 27, 2024 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit d74468e
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66cea25b4628d40008d58307

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 27, 2024 •
edited
Loading

Benchmarks Rust

group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     56.3±2.23ms        ? ?/sec    1.05     58.9±2.05ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     81.9±3.17ms        ? ?/sec    1.03     84.7±3.30ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     98.0±3.06ms        ? ?/sec    1.06    103.7±3.34ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     63.2±2.47ms        ? ?/sec    1.04     65.8±2.61ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    104.6±1.36ms        ? ?/sec    1.01    105.7±1.32ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00   198.1±12.06ms        ? ?/sec    1.01   199.8±10.76ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    246.2±9.80ms        ? ?/sec    1.00    246.7±9.40ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    120.0±1.99ms        ? ?/sec    1.03    123.3±3.93ms        ? ?/sec
bundle/bundle@threejs                                               1.01     38.5±1.94ms        ? ?/sec    1.00     38.3±1.09ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.02     89.1±5.56ms        ? ?/sec    1.00     87.7±5.10ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    107.1±4.89ms        ? ?/sec    1.03    110.0±4.02ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     47.2±0.84ms        ? ?/sec    1.00     47.0±1.06ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    398.7±7.05ms        ? ?/sec    1.00    400.4±5.46ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00    996.6±9.39ms        ? ?/sec    1.00    997.9±7.25ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1261.1±13.94ms        ? ?/sec    1.00  1265.2±15.01ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.01   470.6±10.32ms        ? ?/sec    1.00    467.7±5.86ms        ? ?/sec
remapping/remapping                                                 1.00     33.6±0.27ms        ? ?/sec    1.02     34.2±0.19ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     83.6±0.61ms        ? ?/sec    1.02     85.0±0.48ms        ? ?/sec
scan/scan@rome-ts                                                   1.02     85.9±2.02ms        ? ?/sec    1.00     84.2±1.50ms        ? ?/sec
scan/scan@threejs                                                   1.00     30.1±0.63ms        ? ?/sec    1.00     29.9±1.00ms        ? ?/sec
scan/scan@threejs10x                                                1.00    296.0±3.52ms        ? ?/sec    1.00    295.2±4.06ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review August 28, 2024 04:05
@IWANABETHATGUY IWANABETHATGUY requested a review from hyf0 August 28, 2024 04:05
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit 0205983 Aug 28, 2024
@IWANABETHATGUY IWANABETHATGUY deleted the fix/collect-dependends-symbol branch August 28, 2024 07:03
@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Aug 31, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Aug 31, 2024
@IWANABETHATGUY
fix: collect depended_symbol when canonical_ref has ns_alias (#2095)
ab6b043 
<!-- Thank you for contributing! -->

### Description
1. related to #2079 
<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: thread '<unnamed>' panicked at crates/rolldown/src/types/symbols.rs:68:7:

2 participants

@IWANABETHATGUY @hyf0