Skip to content

fix: collect depended_symbol when canonical_ref has ns_alias #2095

Merged
hyf0 merged 5 commits intomainfrom
fix/rewrite-member-expr-1
Aug 31, 2024
Merged

fix: collect depended_symbol when canonical_ref has ns_alias #2095
hyf0 merged 5 commits intomainfrom
fix/rewrite-member-expr-1

Conversation

@IWANABETHATGUY
Copy link
Copy Markdown
Member

@IWANABETHATGUY IWANABETHATGUY commented Aug 31, 2024 •
edited
Loading

Description

  1. related to fix: collect-dependends-symbol #2079

@netlify
Copy link
Copy Markdown

netlify bot commented Aug 31, 2024 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 1d7cfcb
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66d32ff69b1d4600087e13d5

@IWANABETHATGUY IWANABETHATGUY changed the title Fix/rewrite member expr 1 fix: rewrite member expr 1 Aug 31, 2024
@IWANABETHATGUY IWANABETHATGUY changed the title fix: rewrite member expr 1 fix: depended member expr symbol when canonical_ref has ns_alias Aug 31, 2024
@IWANABETHATGUY IWANABETHATGUY changed the title fix: depended member expr symbol when canonical_ref has ns_alias fix: collect depended_sybmol when canonical_ref has ns_alias Aug 31, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 31, 2024

Benchmarks Rust

group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     52.9±0.90ms        ? ?/sec    1.00     52.7±0.69ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     75.6±0.83ms        ? ?/sec    1.01     76.6±1.96ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     92.9±1.16ms        ? ?/sec    1.00     92.9±1.07ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     60.8±0.75ms        ? ?/sec    1.01     61.1±1.00ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    100.8±1.11ms        ? ?/sec    1.03    103.6±1.25ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.01    187.8±5.07ms        ? ?/sec    1.00    185.3±4.78ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    229.4±3.14ms        ? ?/sec    1.00    230.1±4.88ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    116.9±1.06ms        ? ?/sec    1.01    118.6±0.96ms        ? ?/sec
bundle/bundle@threejs                                               1.00     36.4±0.53ms        ? ?/sec    1.03     37.7±1.30ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     83.3±1.71ms        ? ?/sec    1.04     86.4±1.47ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    102.2±1.71ms        ? ?/sec    1.02    103.9±2.30ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     45.6±0.47ms        ? ?/sec    1.05     48.0±0.44ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    386.3±3.26ms        ? ?/sec    1.03    399.6±6.61ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1002.9±6.35ms        ? ?/sec    1.03  1034.1±34.92ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1271.2±11.11ms        ? ?/sec    1.13  1436.9±95.71ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    455.4±3.51ms        ? ?/sec    1.03    470.1±4.87ms        ? ?/sec
remapping/remapping                                                 1.07     33.8±0.29ms        ? ?/sec    1.00     31.6±0.54ms        ? ?/sec
remapping/render-chunk-remapping                                    1.01     87.1±0.66ms        ? ?/sec    1.00     86.1±0.46ms        ? ?/sec
scan/scan@rome-ts                                                   1.02     83.0±0.73ms        ? ?/sec    1.00     81.6±0.82ms        ? ?/sec
scan/scan@threejs                                                   1.03     29.7±1.20ms        ? ?/sec    1.00     28.7±0.28ms        ? ?/sec
scan/scan@threejs10x                                                1.00    290.3±2.62ms        ? ?/sec    1.00    289.7±2.44ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review August 31, 2024 15:42
@Boshen Boshen changed the title fix: collect depended_sybmol when canonical_ref has ns_alias fix: collect depended_symbol when canonical_ref has ns_alias Aug 31, 2024
@hyf0 hyf0 added this pull request to the merge queue Aug 31, 2024
Merged via the queue into main with commit ab6b043 Aug 31, 2024
@hyf0 hyf0 deleted the fix/rewrite-member-expr-1 branch August 31, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IWANABETHATGUY @hyf0