perf: improve generate_namespace_definition#1986
Merged
IWANABETHATGUY merged 2 commits intorolldown:mainfrom Aug 15, 2024
shulaoda:perf/improve-generate-namespace-definition
Merged
perf: improve generate_namespace_definition#1986IWANABETHATGUY merged 2 commits intorolldown:mainfrom shulaoda:perf/improve-generate-namespace-definition
IWANABETHATGUY merged 2 commits intorolldown:mainfrom
shulaoda:perf/improve-generate-namespace-definition
Conversation
Member
Author
|
@7086cmd cc |
✅ Deploy Preview for rolldown-rs canceled.
|
7086cmd
reviewed
Aug 15, 2024
IWANABETHATGUY
approved these changes
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to #1861
rolldown/crates/rolldown/src/ecmascript/format/utils/namespace.rs
Lines 49 to 51 in 745c1a5