feat: support namespaced name and output.extend for IIFE format.#1861
Merged
underfin merged 36 commits intorolldown:mainfrom Aug 13, 2024
Merged
feat: support namespaced name and output.extend for IIFE format.#1861underfin merged 36 commits intorolldown:mainfrom
output.extend for IIFE format.#1861underfin merged 36 commits intorolldown:mainfrom
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
output.extend for IIFE format.output.extend for IIFE format.
Contributor
Author
|
Rollup document related:
|
underfin
approved these changes
Aug 13, 2024
Contributor
|
Thank you. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 15, 2024
<!-- Thank you for contributing! --> ### Description Related to #1861 https://github.com/rolldown/rolldown/blob/745c1a57e66433df7182b5f9f4aa65aa00aa001b/crates/rolldown/src/ecmascript/format/utils/namespace.rs#L49-L51 <!-- Please insert your description here and provide especially info about the "what" this PR is solving -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request supports the use of namespaced names (including the dot character) and the
output.extendoption for IIFE format aligning with Rollup. Tests are included, and further refactoring is planned (not included in this PR, as it is better to conduct refactoring when more formats are supported, in my opinion).