feat(node): support CLI options.#1963
Merged
IWANABETHATGUY merged 19 commits intorolldown:mainfrom Aug 14, 2024
Merged
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
7086cmd
commented
Aug 13, 2024
Member
|
review this after #1954 is solved. |
4a74863 to
0125ee1
Compare
d0cf028 to
7575f00
Compare
4f43f6f to
ce88d18
Compare
IWANABETHATGUY
approved these changes
Aug 14, 2024
Member
|
Overall looks good, and could be polished in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1955.
This public relations campaign leverages the
parseArgsfunction provided by thenode:utilmodule and the JSON schema generated by thezodlibrary to automatically generate CLI options. This approach enhances the elegance and convenience of the process.In my opinion, the runtime-generated schema is performance-degrading. While it is feasible to generate it during compilation via a plugin, it is currently too complex for this particular pull request, and also requires support
TypeScriptfor config file.