Remove SwapFuncCallArgumentsRector as keeps swaping to infinity, use custom rule instead#4874
Merged
TomasVotruba merged 6 commits intomainfrom Aug 28, 2023
Merged
Remove SwapFuncCallArgumentsRector as keeps swaping to infinity, use custom rule instead#4874TomasVotruba merged 6 commits intomainfrom
TomasVotruba merged 6 commits intomainfrom
Conversation
aa56294 to
00b0cae
Compare
TomasVotruba
commented
Aug 28, 2023
Comment on lines
+122
to
+125
| if ($this->annotationsToAttributes === []) { | ||
| throw new ConfigurationException(sprintf('The "%s" rule requires configuration.', self::class)); | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
It seems people add this rule and expect to convert all annotations to attributes. Then they come to Github issue to report.
Instead, we can make this feedback loop shorter and let them now immediately :)
b0ba1f1 to
de9ec62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #4766
The SwapFuncCallArgumentsRector keeps swaping argument on every single Rector run. This will lead to broken code on 2nd run and is hard to spot. Instead use custom rule to change the arguments position, checking for type, name etc. to make sure the swap happens once and rule is deterministic 👍