Remove SwapMethodCallArgumentsRector as could lead to infinite swapping, use custom rule with type/value check instead#4766
Merged
TomasVotruba merged 1 commit intomainfrom Aug 11, 2023
Conversation
…ng, use custom rule with type/value check instead
Contributor
|
Yes indeed, I see the problem. I will use the custom one on my side instead. |
Member
Author
|
@gaydamakha Thanks for understanding 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced #3726
Since then I've realized this rule could lead to infinite argument swaps on each run. Which would condition to run Rector just once and make usage confusing.
Instead, it's better to create a custom rule for these swaps and check e.g. argument type and variable name to match their new positions. Only that way the rule can be idempotent and usable in CI 👍