[BetterPhpDocParser] Enable textBetweenTagsBelongsToDescription on BetterPhpDocParser extends PhpDocParser#4817
Merged
TomasVotruba merged 15 commits intomainfrom Aug 20, 2023
Merged
Conversation
b3e4709 to
1fb1918
Compare
Member
Author
|
It seems it cause error: 1m 2s
Run bin/rector process src tests rules-tests packages packages-tests --ansi
0/1420 [░░░░░░░░░░░░░░░░░░░░░░░░░░░░] 0%
160/1420 [▓▓▓░░░░░░░░░░░░░░░░░░░░░░░░░] 11%
580/1420 [▓▓▓▓▓▓▓▓▓▓▓░░░░░░░░░░░░░░░░░] 40%
1280/1420 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓░░░] 90%
1 file with changes
===================
1) packages/BetterPhpDocParser/PhpDocParser/BetterPhpDocParser.php:3
---------- begin diff ----------
@@ @@
namespace Rector\BetterPhpDocParser\PhpDocParser;
-use Nette\Utils\Strings;
use PhpParser\Node;
use PHPStan\PhpDocParser\Ast\PhpDoc\ParamTagValueNode;
use PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocChildNode;
----------- end diff -----------
[ERROR] Could not process
"/home/runner/work/rector-src/rector-src/packages/PhpDocParser/PhpDocPa
rser/PhpDocNodeTraverser.php" file, due to:
"System error: ""
Run Rector with "--debug" option and post the report here:
https://github.com/rectorphp/rector/issues/new
". On line:
56 Ref https://github.com/rectorphp/rector-src/actions/runs/5915943638/job/16042686926?pr=4817#step:6:31 |
Member
Author
|
@TomasVotruba it works 🎉 🎉 🎉 |
Member
Author
|
Finally works 🎉 🎉 🎉 All checks have passed 🎉 🎉 🎉 @TomasVotruba I think it is ready. |
3ba8312 to
e8f8117
Compare
Member
Author
|
Rebased. |
…tterPhpDocParser extends PhpDocParser
e8f8117 to
fd70751
Compare
Member
Author
|
Rebased. |
Member
|
Let's ship this 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4482