Skip to content

[BetterPhpDocParser] Enable textBetweenTagsBelongsToDescription on BetterPhpDocParser extends PhpDocParser#4817

Merged
TomasVotruba merged 15 commits intomainfrom
enable-text-between-tags
Aug 20, 2023
Merged

[BetterPhpDocParser] Enable textBetweenTagsBelongsToDescription on BetterPhpDocParser extends PhpDocParser#4817
TomasVotruba merged 15 commits intomainfrom
enable-text-between-tags

Conversation

@samsonasik
Copy link
Copy Markdown
Member

Closes #4482

@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Aug 20, 2023

It seems it cause error:

1m 2s
Run bin/rector process src tests rules-tests packages packages-tests --ansi
    0/1420 [░░░░░░░░░░░░░░░░░░░░░░░░░░░░]   0%
  160/1420 [▓▓▓░░░░░░░░░░░░░░░░░░░░░░░░░]  11%
  580/1420 [▓▓▓▓▓▓▓▓▓▓▓░░░░░░░░░░░░░░░░░]  40%
 1280/1420 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓░░░]  90%

1 file with changes
===================

1) packages/BetterPhpDocParser/PhpDocParser/BetterPhpDocParser.php:3

    ---------- begin diff ----------
@@ @@

 namespace Rector\BetterPhpDocParser\PhpDocParser;

-use Nette\Utils\Strings;
 use PhpParser\Node;
 use PHPStan\PhpDocParser\Ast\PhpDoc\ParamTagValueNode;
 use PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocChildNode;
    ----------- end diff -----------

                                                                                
 [ERROR] Could not process                                                      
         "/home/runner/work/rector-src/rector-src/packages/PhpDocParser/PhpDocPa
         rser/PhpDocNodeTraverser.php" file, due to:                            
         "System error: ""                                                      
         Run Rector with "--debug" option and post the report here: 
https://github.com/rectorphp/rector/issues/new
". On line:
         56                                                                     

Ref https://github.com/rectorphp/rector-src/actions/runs/5915943638/job/16042686926?pr=4817#step:6:31

@samsonasik
Copy link
Copy Markdown
Member Author

@TomasVotruba it works 🎉 🎉 🎉

@samsonasik
Copy link
Copy Markdown
Member Author

Finally works 🎉 🎉 🎉 All checks have passed 🎉 🎉 🎉 @TomasVotruba I think it is ready.

@samsonasik samsonasik force-pushed the enable-text-between-tags branch from 3ba8312 to e8f8117 Compare August 20, 2023 10:17
@samsonasik
Copy link
Copy Markdown
Member Author

Rebased.

@samsonasik samsonasik force-pushed the enable-text-between-tags branch from e8f8117 to fd70751 Compare August 20, 2023 10:27
@samsonasik
Copy link
Copy Markdown
Member Author

Rebased.

@TomasVotruba
Copy link
Copy Markdown
Member

Let's ship this 👍

@TomasVotruba TomasVotruba enabled auto-merge (squash) August 20, 2023 10:28
@TomasVotruba TomasVotruba merged commit cc46e7f into main Aug 20, 2023
@TomasVotruba TomasVotruba deleted the enable-text-between-tags branch August 20, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants