RemoveUselessReturnTagRector doesn't recognize tag comments on a new line given a PHP core type hint#4482
Closed
TravisCarden wants to merge 1 commit intorectorphp:mainfrom
TravisCarden:patch-2
Closed
RemoveUselessReturnTagRector doesn't recognize tag comments on a new line given a PHP core type hint#4482TravisCarden wants to merge 1 commit intorectorphp:mainfrom TravisCarden:patch-2
TravisCarden wants to merge 1 commit intorectorphp:mainfrom
TravisCarden:patch-2
Conversation
samsonasik
reviewed
Jul 11, 2023
...assMethod/RemoveUselessReturnTagRector/Fixture/multiline_comment_for_core_php_return.php.inc
Show resolved
Hide resolved
Member
|
@TravisCarden I cherry-picked your commit at PR #4817 |
Contributor
Author
|
Nice, thanks, @samsonasik! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Report
RemoveUselessReturnTagRectordoesn't seem to recognize@returntag comments if they're on a new line and the@returnhas PHP core type hint--it incorrectly considers the@paramuseless.Minimal PHP Code Causing Issue
See https://getrector.com/demo/2f905b5e-abf3-4268-b95f-096f49fd8b3f
Responsible rules
RemoveUselessReturnTagRectorExpected Behavior
Rector should skip it.