Skip to content
/ rector-src Public

[DX] Fix hang on twice run after all files processed cached#4521

Merged
samsonasik merged 1 commit intomainfrom
fix-hang-on-no-files
Jul 15, 2023
Merged

[DX] Fix hang on twice run after all files processed cached#4521
samsonasik merged 1 commit intomainfrom
fix-hang-on-no-files

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented Jul 15, 2023

@TomasVotruba @staabm PR:

cause hang on twice run after cached on count filtered files already zero:

➜  CodeIgniter4 git:(develop) ✗ time vendor/bin/rector 
 783/783 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

                                                                                                                        
 [OK] Rector is done!                                                                                                   
                                                                                                                        

vendor/bin/rector  266.09s user 7.52s system 709% cpu 38.567 total
➜  CodeIgniter4 git:(develop) ✗ time vendor/bin/rector
    0 [░░░░░░░░░░░░░░░░░░░░░░░░░░░░

This patch fixed it:

➜  CodeIgniter4 git:(develop) ✗ time vendor/bin/rector


                                                                                                                        
 [OK] Rector is done!                                                                                                   
                                                                                                                        

vendor/bin/rector  0.94s user 0.15s system 99% cpu 1.097 total

@samsonasik samsonasik requested a review from TomasVotruba as a code owner July 15, 2023 12:05
@samsonasik samsonasik enabled auto-merge (squash) July 15, 2023 12:06
@samsonasik samsonasik merged commit 45c46dd into main Jul 15, 2023
@samsonasik samsonasik deleted the fix-hang-on-no-files branch July 15, 2023 12:07
@samsonasik samsonasik mentioned this pull request Jul 15, 2023
Merged
@TomasVotruba
Copy link
Copy Markdown
Member

TomasVotruba commented Jul 15, 2023

👍

@samsonasik samsonasik mentioned this pull request Jul 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samsonasik @TomasVotruba