[ApplicationFileProcessor] Refactor ApplicationFileProcessor to filter file paths early before run both parallel and non-parallel#4519
Merged
samsonasik merged 1 commit intomainfrom Jul 15, 2023
Conversation
…r file paths early before run both parallel and non-parallel
Member
Author
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
Member
Author
|
@TomasVotruba @staabm it works 🎉 , tested in CodeIgniter 4 project: Before, show 790 files counted After, show 783 files counted which the correct files that filtered by file extensions config. so the progress bar is also 100% without tweaking finish :) |
This was referenced Jul 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #4513 (comment)
@TomasVotruba @staabm this filter file paths by supported file extensions early before process parallel or non-parallel so file counts will correctly counted, this revert the progress bar tweak on PR:
as the file now counted correctly on parallel.
We may need to centralize the process between parallel and non-parallel file process to avoid copy paste code if there is needed change, but that's will need separate PR :)