Skip to content
/ rector-src Public

[DX] Show progress bar 100% on RectorConsoleOutputFormatter::report()#4516

Merged
samsonasik merged 2 commits intomainfrom
show-progress
Jul 14, 2023
Merged

[DX] Show progress bar 100% on RectorConsoleOutputFormatter::report()#4516
samsonasik merged 2 commits intomainfrom
show-progress

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented Jul 14, 2023

@samsonasik samsonasik requested a review from TomasVotruba as a code owner July 14, 2023 19:42
@samsonasik samsonasik mentioned this pull request Jul 14, 2023
Merged
@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Jul 14, 2023

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit d41685d into main Jul 14, 2023
@samsonasik samsonasik deleted the show-progress branch July 14, 2023 19:47
@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Jul 14, 2023

@TomasVotruba it works 🎉 ;)

@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Jul 14, 2023

Tested in CodeIgniter4 project:

Before only show 99%

➜  CodeIgniter4 git:(develop) ✗ time vendor/bin/rector process --clear-cache
 783/790 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓░]  99%

                                                                                
 [OK] Rector is done!                                                           
                                                                                

vendor/bin/rector process --clear-cache  292,09s user 4,52s system 764% cpu 38,809 total

After: show 100%

➜  CodeIgniter4 git:(develop) ✗ time vendor/bin/rector process --clear-cache
 790/790 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

                                                                                
 [OK] Rector is done!                                                           
                                                                                

vendor/bin/rector process --clear-cache  284,86s user 4,23s system 760% cpu 38,004 total

@samsonasik samsonasik mentioned this pull request Jul 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@samsonasik