[Privatization] Skip variable assign append on ChangeReadOnlyVariableWithDefaultValueToConstantRector#3687
Conversation
samsonasik
left a comment
There was a problem hiding this comment.
Please add fixture test under
If it going to skip the change, you can copy one of fixture file with skip_ prefix and modify
...ngeReadOnlyVariableWithDefaultValueToConstantRector/Fixture/skip_variable_assignment.php.inc
Outdated
Show resolved
Hide resolved
...ngeReadOnlyVariableWithDefaultValueToConstantRector/Fixture/skip_variable_assignment.php.inc
Show resolved
Hide resolved
samsonasik
left a comment
There was a problem hiding this comment.
Please rename PR title to something like:
[Privatization] Skip variable assign append on ChangeReadOnlyVariableWithDefaultValueToConstantRector
Also, could you make CI green, see error
https://github.com/rectorphp/rector-src/actions/runs/4803271285/jobs/8547601933?pr=3687#step:5:18
|
@samsonasik could you please check why testing fails on Renaming/Rector/FileWithoutNamespace/PseudoNamespaceToNamespaceRector/Fixture/namespace_split.php.inc? I didn't change that file. Thanks! |
|
I am not sure, could you try rebase? If still happen, try revert your change, if still happen, it possibly due to duplicated fixture files |
|
Test failure fixed at #3691, please rebase |
|
@mickeytodd @samsonasik Thanks for fixing this so quickly! |
…WithDefaultValueToConstantRector (#3687) * fix: checking for other modifying types * fix: added fixture * fix: changed class name * fix: checking if parent class is null * fix: checking for all types of assigning
Closes rectorphp/rector#7900