Skip to content

Update phpdoc-parser to ^1.20.3#3691

Merged
samsonasik merged 2 commits intomainfrom
update-phpdoc-praser
Apr 27, 2023
Merged

Update phpdoc-parser to ^1.20.3#3691
samsonasik merged 2 commits intomainfrom
update-phpdoc-praser

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@TomasVotruba let's try this to ensure no error :

Call to undefined method                               
         Rector\BetterPhpDocParser\ValueObject\Parser\BetterTokenIterator::getTokens()

if the issue persist, inner dependency probably cause to load old phpdoc-parser.

https://github.com/rectorphp/rector-symfony/actions/runs/4808249189/jobs/8557993664?pr=394#step:5:14

@TomasVotruba
Copy link
Copy Markdown
Member

I think it's related to this one:
f26a476

@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Apr 27, 2023

Yesterday is working ok, that change was 5 days ago, test failure like that may due to duplicated fixture

@samsonasik samsonasik self-assigned this Apr 27, 2023
@samsonasik
Copy link
Copy Markdown
Member Author

@TomasVotruba fixed 🎉

@TomasVotruba
Copy link
Copy Markdown
Member

Thank you 👏

samsonasik added a commit that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants