Skip to content

[Printer] Handle commented code before closing tag on no rule applied print on PhpFileProcessor#3488

Merged
samsonasik merged 3 commits intomainfrom
close-3486
Mar 18, 2023
Merged

[Printer] Handle commented code before closing tag on no rule applied print on PhpFileProcessor#3488
samsonasik merged 3 commits intomainfrom
close-3486

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik
Copy link
Copy Markdown
Member Author

Fixed 🎉 /cc @bigahuna @schlndh

@samsonasik samsonasik changed the title [Printer] Handle commented code no rule applied print on PhpFileProcessor [Printer] Handle commented code before closing tag on no rule applied print on PhpFileProcessor Mar 18, 2023
@samsonasik samsonasik enabled auto-merge (squash) March 18, 2023 09:38
@samsonasik samsonasik merged commit fd7a99a into main Mar 18, 2023
@samsonasik samsonasik deleted the close-3486 branch March 18, 2023 09:40
samsonasik added a commit that referenced this pull request May 8, 2023
… print on PhpFileProcessor (#3488)

* add failing plain view test fixture

* Closes #3486 Fixes rectorphp/rector#7845 Fixes rectorphp/rector#7841

* more fixture

---------

Co-authored-by: schlndh <schlndh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Indentation change in mixed HTML/PHP file that's unaffected by rule Rector removes leading spaces before <?php endif; ?>

2 participants