add failing plain view test fixture#3486
Closed
schlndh wants to merge 1 commit intorectorphp:mainfrom
Closed
Conversation
Member
|
That possibly seems regex only replace once on this case, and not replace in another open tag, could you try to provide a patch for it? Thank you. |
Member
|
I checked the diff, it seems the printed content from php-parser doesn't remove the first starter of foreach:
https://www.diffchecker.com/1y97KyQF the regex should apply to both printed content and regex content of original content, I will create PR for it |
samsonasik
added a commit
that referenced
this pull request
Mar 18, 2023
Member
samsonasik
added a commit
that referenced
this pull request
Mar 18, 2023
… print on PhpFileProcessor (#3488) * add failing plain view test fixture * Closes #3486 Fixes rectorphp/rector#7845 Fixes rectorphp/rector#7841 * more fixture --------- Co-authored-by: schlndh <schlndh@users.noreply.github.com>
samsonasik
added a commit
that referenced
this pull request
May 8, 2023
… print on PhpFileProcessor (#3488) * add failing plain view test fixture * Closes #3486 Fixes rectorphp/rector#7845 Fixes rectorphp/rector#7841 * more fixture --------- Co-authored-by: schlndh <schlndh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rectorphp/rector#7845
It seems that the issue is not
OPEN_TAG_SPACED_REGEXas was suggested in the issue, but rather the fact that only one of the<?phpis indented incorrectly, while the other one remains correctly indented. So this condition is not triggered.