[AutoImport][PostRector] Handle duplicated import on namespaced class on UseAddingPostRector#3461
Merged
samsonasik merged 9 commits intomainfrom Mar 7, 2023
Merged
Conversation
…ensioRouteAnnotationWithSymfonyRector
Member
Author
|
All checks have passed 🎉 @TomasVotruba I think it is ready. |
Member
Author
|
@TomasVotruba I am merging it ;) |
samsonasik
added a commit
that referenced
this pull request
May 8, 2023
… on UseAddingPostRector (#3461) * [AutoImport] Handle duplicated import on namespaced class on ReplaceSensioRouteAnnotationWithSymfonyRector * [ci-review] Rector Rectify * moving to early clean before add to namespace or non-namespace * [ci-review] Rector Rectify * removing use under namespace * Fixed 🎉 * Fix phpstan * Final touch: clean up * Final touch: clean up --------- Co-authored-by: GitHub Action <actions@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue of PR:
When auto import is namespaced, the old classname should be cleaned up before add to avoid duplicated import.
Given the following config:
with class:
It currently produce duplicated use statement.
namespace App; +use Symfony\Component\Routing\Annotation\Route; use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route; use Symfony\Bundle\FrameworkBundle\Controller\Controller;This PR try to fix it.