[Renaming] Keep unused import unless configured $rectorConfig->removeUnusedImports() on RenameClassRector on no namespace#3460
Merged
samsonasik merged 8 commits intomainfrom Mar 6, 2023
Conversation
…UnusedImports() on RenameClassRector on no namespace
Member
Author
|
Fixed 🎉 |
Member
Author
|
rector-symfony test need to updated to cover this: There were 3 failures:
1) Rector\Symfony\Tests\Set\Symfony62\Symfony62Test::test with data set #0
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
<?php
+use Sensio\Bundle\FrameworkExtraBundle\Configuration\IsGranted;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Routing\Annotation\Route; |
Member
Author
|
I created PR to rector-symfony for it rectorphp/rector-symfony#375 |
Member
Author
|
Re-start build |
Member
Author
|
All checks have passed 🎉 @TomasVotruba I think it is ready. |
Member
Author
|
@TomasVotruba I am merging it ;) |
This was referenced Mar 6, 2023
samsonasik
added a commit
that referenced
this pull request
May 8, 2023
…UnusedImports() on RenameClassRector on no namespace (#3460) * [Renaming] Keep unused import unless configured $rectorConfig->removeUnusedImports() on RenameClassRector on no namespace * clean up fixture * Fixed 🎉 * fix * clean up * clean up * final touch: eol * Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
$rectorConfig->removeUnusedImports()is not used, the unused import should be kept, this is only happen on no namespace, ref:Without namespace (got removed) : https://getrector.com/demo/1fe1232a-4741-4564-b225-8f0822338071
With namespace (unused use is kept) : https://getrector.com/demo/b4de0818-8ca3-496b-92c7-6f54e9ffd4cd
Fixes rectorphp/rector#7549