Skip to content

[3-1-stable] Resolve deprecation warnings about uri DEFAULT_PARSER (#2242)#2249

Merged
ioquatix merged 1 commit into
rack:3-1-stablefrom
Earlopain:backport-uri-3.1
Oct 14, 2024
Merged

[3-1-stable] Resolve deprecation warnings about uri DEFAULT_PARSER (#2242)#2249
ioquatix merged 1 commit into
rack:3-1-stablefrom
Earlopain:backport-uri-3.1

Conversation

@Earlopain

Copy link
Copy Markdown
Contributor

Backport #2242 to 3-1-stable. Forgot to open this

Ruby switches the default parser from RFC2396 to RFC3986. This parser contains
all methods from the old parser but delegates to RFC2396 for a few and warns.
Namely `extract`, `make_regexp`, `escape`,and `unescape`.

Since the RFC2396 alias is not available for old rubies, do a defined check and select the appropriate one.
This will work for all versions without warnings.

@ioquatix ioquatix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this. Thanks.

@ioquatix ioquatix merged commit f4f7103 into rack:3-1-stable Oct 14, 2024
@ioquatix ioquatix added this to the v3.1.8 milestone Oct 14, 2024
@ioquatix

Copy link
Copy Markdown
Member

Released in Rack v3.1.8.

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants