Resolve deprecation warnings about uri DEFAULT_PARSER#2242
Merged
Conversation
Member
|
This looks good to me, but I'll fix the external tests tomorrow. |
jeremyevans
approved these changes
Aug 28, 2024
e882c52 to
5b22114
Compare
Ruby switches the default parser from RFC2396 to RFC3986. This parser contains all methods from the old parser but delegates to RFC2396 for a few and warns. Namely `extract`, `make_regexp`, `escape`,and `unescape`. Since the RFC2396 alias is not available for old rubies, do a defined check and select the appropriate one. This will work for all versions without warnings.
5b22114 to
29adcec
Compare
Member
|
Thanks for your contribution and the great commit message. |
Earlopain
added a commit
to Earlopain/rack
that referenced
this pull request
Oct 2, 2024
Ruby switches the default parser from RFC2396 to RFC3986. This parser contains all methods from the old parser but delegates to RFC2396 for a few and warns. Namely `extract`, `make_regexp`, `escape`,and `unescape`. Since the RFC2396 alias is not available for old rubies, do a defined check and select the appropriate one. This will work for all versions without warnings.
ioquatix
pushed a commit
that referenced
this pull request
Oct 14, 2024
Ruby switches the default parser from RFC2396 to RFC3986. This parser contains all methods from the old parser but delegates to RFC2396 for a few and warns. Namely `extract`, `make_regexp`, `escape`,and `unescape`. Since the RFC2396 alias is not available for old rubies, do a defined check and select the appropriate one. This will work for all versions without warnings.
Earlopain
pushed a commit
to Earlopain/rack
that referenced
this pull request
Jan 30, 2025
Ruby switches the default parser from RFC2396 to RFC3986. This parser contains all methods from the old parser but delegates to RFC2396 for a few and warns. Namely `extract`, `make_regexp`, `escape`,and `unescape`. Since the RFC2396 alias is not available for old rubies, do a defined check and select the appropriate one. This will work for all versions without warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby switches the default parser from RFC2396 to RFC3986. This parser contains all methods from the old parser but delegates to RFC2396 for a few and warns. Namely
extract,make_regexp,escape,andunescape.Since the RFC2396 alias is not available for old rubies, do a defined check and select the appropriate one. This will work for all versions without warnings.
Additional info:
While this removes the warning and passes tests, I can't describe the possible impact for continuing to use the older parser like this. I'll leave that up to someone with more domain knowledge, consider this a notice about the warning if that turns out to be important.