fix: ignore installed when running pip#1040
Merged
Merged
Conversation
This isn't normally possible, as it's a new environment, but PYTHONPATH can cause pip to see stuff that's not in there. Assisted-by: OpenCode:Kimi-K2.5 Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
0b45cb0 to
6162ab5
Compare
Member
|
This works but it'd be a good to have a test which verifies that it does. |
Contributor
Author
|
I thought about it, you'd have to set up a separate venv, point the PYTHONPATH there, and then see if it still installs and builds? Or do you have a better idea for a test? This does verify that the flag gets passed. |
Member
|
How's this? |
Member
|
We should probably add pip as a test dependency if you're okay with the test. |
henryiii
commented
Apr 16, 2026
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
4367293 to
de45fc0
Compare
layday
approved these changes
Apr 17, 2026
Signed-off-by: Henry Schreiner <henryfs@prinecton.edu>
Contributor
Author
|
@layday & @gaborbernat I think we are good for a patch release? |
Collaborator
|
Yes. |
Contributor
Author
Closed
2 tasks
hoodmane
added a commit
to hoodmane/pyodide-build
that referenced
this pull request
Apr 28, 2026
Workaround for pypa/build#1040 installing over our cross numpy and scipy.
hoodmane
added a commit
to pyodide/pyodide-build
that referenced
this pull request
Apr 28, 2026
Workaround for pypa/build#1040 installing over our cross numpy and scipy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1037. Alternative, to, and closes #1038.
This isn't normally possible, as it's a new environment, but
PYTHONPATHcan cause pip to see stuff that's not in there.Should not be required for uv, since it doesn't need
PYTHONPATHto run, while pip might.🤖 Assisted-by: OpenCode:Kimi-K2.5
Changelog
docs/changelog/<pr_number>.<type>.rstfeature,bugfix,doc,removal,misc123.feature.rstcontainingAdd custom backend support - by :user:`yourname`Checklist
tox)tox -e fix)tox -e type)tox -e docs)