fix: PYTHONPATH only partially removed#1038
Conversation
4a62725 to
8cf1bb1
Compare
8cf1bb1 to
d4c1ae2
Compare
|
Once @layday reviews, this is good to merge, and we can have a quick patch release. |
|
What happens if the outer pip is on the Python path? This will always be the case e.g. in a Nix dev shell. |
|
As long as its path gets resolved correctly, shouldn't it be fine? You don't been PYTHONPATH set to call pip. |
|
You do if pip itself is on
|
|
Ahh, we do use Should we just revert the PYTHONPATH changes in the last release? Or we could disable PYTHONPATH when looking for pip. But it looks like we use We could also just refuse to look for pip if PYTHONPATH is set. |
Meaning #1024? It looks like it isolates the backend runner, but the linked issue (#405) is about
How do we do that other than by attempting to parse and subtract We could just try passing |
|
I've not used that before, we could try? Hopefully it's not new so we don't get bit with even more version-specific behavior. :) (Edit: looks like it's old, good) |
Assisted-by: OpenCode:Kimi-K2.5 Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
7dbbe76 to
bcdb4f0
Compare
|
Coverage is a bit short, but I tried something different. I tried to create a couple of tests to mimic this (with AI help), and implemented its suggestion as a fix. For |
|
Can you be a bit more specific about |
|
Oh, I think I was thinking about usage too, yeah, that might work. I'll make an alternate PR with that. |
Description
Remove the
PYTHONPATHsetting from_pip_env. From the "possible solution", I think this should help #1037?🤖 Assisted-by: OpenCode:Kimi-K2.5 - used to quickly implement the suggestion and a few tests, then iterated by hand on this to just remove vs. override.
Changelog
docs/changelog/<pr_number>.<type>.rstfeature,bugfix,doc,removal,misc123.feature.rstcontainingAdd custom backend support - by :user:`yourname`Checklist
tox)tox -e fix)tox -e type)tox -e docs)