Allow default_encoding callable to return None#951
Merged
Conversation
ccb29ca to
8d89826
Compare
default_encoding callable to return None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Widens
default_encoding's callable signature fromCallable[[bytes], str]toCallable[[bytes], str | None].Response.encodingalready handles aNonereturn via theencoding or "utf-8"fallback at the end of the property, and our owndocs/advanced/text-encodings.mdexample useschardet.detect(content).get("encoding"), which can returnNone.Backport of upstream encode/httpx#3079 by @JelleZijlstra (still open upstream, but the change is straightforwardly correct).
Test plan
mypypassesAI Disclaimer
This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.