Types: Fix type annotation for default_encoding parameter#3079
Open
JelleZijlstra wants to merge 1 commit into
Open
Types: Fix type annotation for default_encoding parameter#3079JelleZijlstra wants to merge 1 commit into
JelleZijlstra wants to merge 1 commit into
Conversation
The default encoding function is allowed to return None, in which case the encoding property of httpx.Response defaults to utf-8. The example in https://www.python-httpx.org/advanced/#using-character-set-auto-detection that passes a default_encoding function uses a function that may return None.
T-256
approved these changes
Feb 2, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default encoding function is allowed to return None, in which case
the encoding property of httpx.Response defaults to utf-8.
The example in https://www.python-httpx.org/advanced/#using-character-set-auto-detection
that passes a default_encoding function uses a function that may return None.
Checklist