fix(version): honor workspace selection for recursive version bumps (#11425)

aayushbaluni · zkochan · web-flow · commit 9d0a3006ffd0 · 2026-06-17T11:22:15.000+02:00
## Problem `pnpm version --recursive` did not bump the workspace packages the user selected. In recursive mode the command re-derived the workspace selection itself (via `filterProjectsFromDir`) using an incomplete set of options, so it could resolve a different set of packages than the CLI's actual `--filter`/`--recursive` resolution. Fixes #11348. ## Change - In recursive mode, bump the projects in `selectedProjectsGraph` — the selection the pnpm CLI (`main.ts`) already computes from the workspace filter, exactly the way `pnpm publish --recursive` works. - Remove the in-handler `filterProjectsFromDir` fallback. It duplicated the CLI's filtering logic and was unreachable in production (`main.ts` always passes `selectedProjectsGraph` for a recursive run). `@pnpm/workspace.projects-filter` becomes a dev-only dependency of `@pnpm/releasing.commands`. - No global/config plumbing is needed for `--recursive`: `@pnpm/cli.parse-cli-args` already recognizes `recursive` (and the `-r` shorthand) for every command, the config reader passes it through to the handler, and the `version` command already declares `recursive` in its own `cliOptionsTypes`. --------- Co-authored-by: Zoltan Kochan <z@kochan.io>
diff --git a/.changeset/version-recursive-workspace-selection.md b/.changeset/version-recursive-workspace-selection.md
@@ -0,0 +1,6 @@
+---
+"@pnpm/releasing.commands": patch
+"pnpm": patch
+---
+
+Fixed `pnpm version --recursive` so it honors the workspace selection. In recursive mode the version bump now applies to the packages resolved from the workspace filter (`selectedProjectsGraph`), matching the behavior of `pnpm publish --recursive`, instead of always bumping every workspace package [#11348](https://github.com/pnpm/pnpm/issues/11348).
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/pnpm/test/version.ts b/pnpm/test/version.ts
@@ -0,0 +1,32 @@
+import { expect, test } from '@jest/globals'
+import { preparePackages } from '@pnpm/prepare'
+import { loadJsonFileSync } from 'load-json-file'
+import { writeYamlFileSync } from 'write-yaml-file'
+
+import { execPnpm } from './utils/index.js'
+
+test('version --recursive bumps every workspace package', async () => {
+  preparePackages([
+    { name: 'project-1', version: '1.0.0' },
+    { name: 'project-2', version: '2.3.0' },
+  ])
+  writeYamlFileSync('pnpm-workspace.yaml', { packages: ['project-*'] })
+
+  await execPnpm(['version', '--recursive', '--no-git-checks', 'minor'])
+
+  expect(loadJsonFileSync<{ version: string }>('project-1/package.json').version).toBe('1.1.0')
+  expect(loadJsonFileSync<{ version: string }>('project-2/package.json').version).toBe('2.4.0')
+})
+
+test('version --recursive --filter bumps only the selected package', async () => {
+  preparePackages([
+    { name: 'project-1', version: '1.0.0' },
+    { name: 'project-2', version: '2.3.0' },
+  ])
+  writeYamlFileSync('pnpm-workspace.yaml', { packages: ['project-*'] })
+
+  await execPnpm(['version', '--recursive', '--filter', 'project-2', '--no-git-checks', 'patch'])
+
+  expect(loadJsonFileSync<{ version: string }>('project-1/package.json').version).toBe('1.0.0')
+  expect(loadJsonFileSync<{ version: string }>('project-2/package.json').version).toBe('2.3.1')
+})
diff --git a/releasing/commands/package.json b/releasing/commands/package.json
@@ -62,7 +62,6 @@
     "@pnpm/releasing.exportable-manifest": "workspace:*",
     "@pnpm/resolving.resolver-base": "workspace:*",
     "@pnpm/types": "workspace:*",
-    "@pnpm/workspace.projects-filter": "workspace:*",
     "@pnpm/workspace.projects-sorter": "workspace:*",
     "@types/normalize-path": "catalog:",
     "@zkochan/rimraf": "catalog:",
@@ -102,6 +101,7 @@
     "@pnpm/test-ipc-server": "workspace:*",
     "@pnpm/testing.command-defaults": "workspace:*",
     "@pnpm/testing.registry-mock": "workspace:*",
+    "@pnpm/workspace.projects-filter": "workspace:*",
     "@types/cross-spawn": "catalog:",
     "@types/is-windows": "catalog:",
     "@types/libnpmpublish": "catalog:",
diff --git a/releasing/commands/src/version/index.ts b/releasing/commands/src/version/index.ts
@@ -5,7 +5,7 @@ import { type Config, types as allTypes } from '@pnpm/config.reader'
 import { PnpmError } from '@pnpm/error'
 import { runLifecycleHook, type RunLifecycleHookOptions } from '@pnpm/exec.lifecycle'
 import { isGitRepo, isWorkingTreeClean } from '@pnpm/network.git-utils'
-import { filterProjectsFromDir, type WorkspaceFilter } from '@pnpm/workspace.projects-filter'
+import type { ProjectsGraph } from '@pnpm/types'
 import { safeExeca as execa } from 'execa'
 import { pick } from 'ramda'
 import { renderHelp } from 'render-help'
@@ -119,6 +119,7 @@ interface VersionHandlerOptions extends Config {
   message?: string
   preid?: string
   recursive?: boolean
+  selectedProjectsGraph?: ProjectsGraph
   signGitTag?: boolean
   tagVersionPrefix?: string
 }
@@ -149,28 +150,7 @@ export async function handler (
   const changes: VersionChange[] = []
 
   if (opts.recursive) {
-    const workspaceDir = opts.workspaceDir || opts.dir
-    const filters: WorkspaceFilter[] = []
-
-    if (opts.filter && opts.filter.length > 0) {
-      opts.filter.forEach(filterPattern => {
-        filters.push({
-          filter: filterPattern,
-          followProdDepsOnly: !!opts.filterProd && opts.filterProd.length > 0,
-        })
-      })
-    }
-
-    const result = await filterProjectsFromDir(
-      workspaceDir,
-      filters,
-      {
-        workspaceDir,
-        prefix: opts.dir,
-      }
-    )
-
-    const pkgDirs = Object.keys(result.selectedProjectsGraph)
+    const pkgDirs = Object.keys(opts.selectedProjectsGraph ?? {})
     const bumpResults = await Promise.all(
       pkgDirs.map(pkgDir => bumpPackageVersion(pkgDir, rawBump, explicitVersion, opts))
     )
diff --git a/releasing/commands/test/version/index.test.ts b/releasing/commands/test/version/index.test.ts
@@ -383,6 +383,10 @@ fs.appendFileSync(process.argv[2], process.argv[3] + ':' + manifest.version + '\
         dir: tempDir,
         workspaceDir: tempDir,
         recursive: true,
+        selectedProjectsGraph: {
+          [pkgADir]: { dependencies: [], package: {} },
+          [pkgBDir]: { dependencies: [], package: {} },
+        },
       } as any, ['patch']) // eslint-disable-line @typescript-eslint/no-explicit-any
 
       const { stdout: tags } = await execa('git', ['tag', '--list'], { cwd: tempDir })
@@ -394,63 +398,28 @@ fs.appendFileSync(process.argv[2], process.argv[3] + ':' + manifest.version + '\
   })
 
   describe('recursive mode', () => {
-    it('should bump versions of all workspace packages with --recursive', async () => {
-      // Create workspace structure
+    // The happy path (which packages a recursive run selects) is covered end to
+    // end in pnpm/test/version.ts against the real CLI. The cases below exercise
+    // handler branches that do not depend on the CLI selection wiring.
+    it('should honor an empty selectedProjectsGraph and bump nothing', async () => {
       const pkgADir = path.join(tempDir, 'packages', 'pkg-a')
-      const pkgBDir = path.join(tempDir, 'packages', 'pkg-b')
       fs.mkdirSync(pkgADir, { recursive: true })
-      fs.mkdirSync(pkgBDir, { recursive: true })
 
       fs.writeFileSync(path.join(tempDir, 'package.json'), JSON.stringify({ name: 'my-workspace', version: '1.0.0' }))
       fs.writeFileSync(path.join(tempDir, 'pnpm-workspace.yaml'), 'packages:\n  - "packages/*"\n')
       fs.writeFileSync(path.join(pkgADir, 'package.json'), JSON.stringify({ name: 'pkg-a', version: '1.0.0' }))
-      fs.writeFileSync(path.join(pkgBDir, 'package.json'), JSON.stringify({ name: 'pkg-b', version: '2.3.0' }))
-
-      const result = await handler({
-        dir: tempDir,
-        workspaceDir: tempDir,
-        gitChecks: false,
-        gitTagVersion: false,
-        recursive: true,
-      } as any, ['minor']) // eslint-disable-line @typescript-eslint/no-explicit-any
-
-      const resultStr = result as string
-      expect(resultStr).toContain('pkg-a')
-      expect(resultStr).toContain('pkg-b')
-
-      const manifestA = JSON.parse(fs.readFileSync(path.join(pkgADir, 'package.json'), 'utf-8'))
-      const manifestB = JSON.parse(fs.readFileSync(path.join(pkgBDir, 'package.json'), 'utf-8'))
-      expect(manifestA.version).toBe('1.1.0')
-      expect(manifestB.version).toBe('2.4.0')
-    })
-
-    it('should return JSON output in recursive mode with --json', async () => {
-      const pkgDir = path.join(tempDir, 'packages', 'pkg-a')
-      fs.mkdirSync(pkgDir, { recursive: true })
 
-      fs.writeFileSync(path.join(tempDir, 'package.json'), JSON.stringify({ name: 'my-workspace', version: '1.0.0' }))
-      fs.writeFileSync(path.join(tempDir, 'pnpm-workspace.yaml'), 'packages:\n  - "packages/*"\n')
-      fs.writeFileSync(path.join(pkgDir, 'package.json'), JSON.stringify({ name: 'pkg-a', version: '1.0.0' }))
-
-      const result = await handler({
+      await expect(handler({
         dir: tempDir,
         workspaceDir: tempDir,
         gitChecks: false,
         gitTagVersion: false,
         recursive: true,
-        json: true,
-      } as any, ['patch']) // eslint-disable-line @typescript-eslint/no-explicit-any
+        selectedProjectsGraph: {},
+      } as any, ['minor'])).rejects.toThrow('No packages to version') // eslint-disable-line @typescript-eslint/no-explicit-any
 
-      const parsed = JSON.parse(result as string)
-      expect(parsed).toEqual(
-        expect.arrayContaining([
-          expect.objectContaining({
-            name: 'pkg-a',
-            currentVersion: '1.0.0',
-            newVersion: '1.0.1',
-          }),
-        ])
-      )
+      expect(JSON.parse(fs.readFileSync(path.join(pkgADir, 'package.json'), 'utf-8')).version).toBe('1.0.0')
+      expect(JSON.parse(fs.readFileSync(path.join(tempDir, 'package.json'), 'utf-8')).version).toBe('1.0.0')
     })
 
     it('should skip workspace packages without name or version', async () => {
@@ -470,6 +439,10 @@ fs.appendFileSync(process.argv[2], process.argv[3] + ':' + manifest.version + '\
         gitChecks: false,
         gitTagVersion: false,
         recursive: true,
+        selectedProjectsGraph: {
+          [pkgADir]: { dependencies: [], package: {} },
+          [pkgBDir]: { dependencies: [], package: {} },
+        },
       } as any, ['patch']) // eslint-disable-line @typescript-eslint/no-explicit-any
 
       const resultStr = result as string
