Walkthrough

Adds selectedProjectsGraph?: ProjectsGraph to VersionHandlerOptions. In recursive mode, if this field is provided, pkgDirs is derived directly from its keys; otherwise a filterProjectsFromDir call with expanded workspace configuration options is used. Test cases verify behavior with explicit workspace graphs, and a patch changeset documents the fix.

Changes

Recursive version workspace selection

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

• zkochan

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

• X
• Mastodon
• Reddit
• LinkedIn

Description

releasing/commands’s version handler now derives recursive targets exclusively from
opts.selectedProjectsGraph ?? {}, so calling handler() with recursive: true but without a
pre-populated graph will bump nothing and throw NO_PACKAGES_TO_VERSION. This is a behavioral
regression vs. the previous implementation (which computed the graph) and contradicts the PR
description’s stated fallback behavior.

Code

releasing/commands/src/version/index.ts[R151-156]

if (opts.recursive) {
-    const workspaceDir = opts.workspaceDir || opts.dir
-    const filters: WorkspaceFilter[] = []
-
-    if (opts.filter && opts.filter.length > 0) {
-      opts.filter.forEach(filterPattern => {
-        filters.push({
-          filter: filterPattern,
-          followProdDepsOnly: !!opts.filterProd && opts.filterProd.length > 0,
-        })
-      })
-    }
-
-    const result = await filterProjectsFromDir(
-      workspaceDir,
-      filters,
-      {
-        workspaceDir,
-        prefix: opts.dir,
-      }
-    )
-
-    const pkgDirs = Object.keys(result.selectedProjectsGraph)
+    const pkgDirs = Object.keys(opts.selectedProjectsGraph ?? {})
const bumpResults = await Promise.all(
pkgDirs.map(pkgDir => bumpPackageVersion(pkgDir, rawBump, explicitVersion, opts))
)

Evidence

The handler now exclusively uses opts.selectedProjectsGraph to determine which package dirs to
bump; if it is missing, no bumps occur and an error is thrown. selectedProjectsGraph is only
populated by the pnpm CLI harness during recursive execution, so direct/programmatic invocations of
the exported handler do not get this field unless they set it themselves.

releasing/commands/src/version/index.ts[127-171]
pnpm/src/main.ts[260-324]
releasing/commands/src/version/index.ts[315-321]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`releasing/commands/src/version/index.ts` uses `Object.keys(opts.selectedProjectsGraph ?? {})` in recursive mode. When `selectedProjectsGraph` is not provided (e.g. calling `version.handler()` programmatically or in unit tests without going through `pnpm/src/main.ts`), the handler bumps no manifests and throws `NO_PACKAGES_TO_VERSION`.
### Issue Context
The pnpm CLI (`pnpm/src/main.ts`) computes `context.selectedProjectsGraph` only on the recursive CLI path and then spreads it into the options passed to command handlers. That means the handler currently depends on CLI bootstrapping.
### Fix Focus Areas
- releasing/commands/src/version/index.ts[149-171]
### Suggested fix
1. In the `if (opts.recursive)` branch, implement a fallback when `opts.selectedProjectsGraph == null`:
- Compute `workspaceDir` as `opts.workspaceDir ?? opts.dir`.
- Build the same `filters` array pattern used by the CLI (`opts.filter`, `opts.filterProd`).
- Call `filterProjectsFromDir(workspaceDir, filters, { workspaceDir, prefix: opts.dir, patterns: opts.workspacePackagePatterns, engineStrict: opts.engineStrict, nodeVersion: opts.nodeVersion, linkWorkspacePackages: !!opts.linkWorkspacePackages, testPattern: opts.testPattern, changedFilesIgnorePattern: opts.changedFilesIgnorePattern, useGlobDirFiltering: !opts.legacyDirFiltering, sharedWorkspaceLockfile: opts.sharedWorkspaceLockfile })`.
- Use the returned `selectedProjectsGraph` keys as `pkgDirs`.
2. If you reintroduce `filterProjectsFromDir` at runtime, ensure `@pnpm/workspace.projects-filter` is a runtime dependency again (or dynamically import it inside the fallback so the common CLI path does not pay for it).
3. Add/adjust tests to cover the fallback path explicitly (a direct `handler({ recursive: true, dir, workspaceDir, filter: [...] })` call without `selectedProjectsGraph` should still bump the expected packages).

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)