Skip to content

Add rule test cases for issues fixed with PMD 7.0.0#5300

Merged
adangel merged 63 commits intopmd:mainfrom
adangel:pmd7-bug-fix-verification
Nov 28, 2024
Merged

Add rule test cases for issues fixed with PMD 7.0.0#5300
adangel merged 63 commits intopmd:mainfrom
adangel:pmd7-bug-fix-verification

Conversation

@adangel
Copy link
Copy Markdown
Member

@adangel adangel commented Oct 31, 2024

Describe the PR

This adds regression test cases for the issues, that we fixed/closed with PMD 7.0.0.
All the mentioned issues should already be resolved and milestoned to 7.0.0.

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed) - not needed, as no new issues have been fixed.

@adangel adangel added this to the 7.8.0 milestone Oct 31, 2024
@ghost
Copy link
Copy Markdown

ghost commented Oct 31, 2024

1 Message
📖 No regression tested rules have been changed.

Generated by 🚫 Danger

@adangel
Copy link
Copy Markdown
Member Author

adangel commented Nov 28, 2024

FYI - I'm going to merge this now. These tests represent how PMD currently works. Whether this is correct or not (see e.g. #4869) is a different task - in that case, we need to adjust either rules, tests or both.
In anyway, these test cases help to avoid that we accidentally introduce regressions for issues, that we considered to be fixed.

@adangel adangel merged commit 18fb574 into pmd:main Nov 28, 2024
adangel added a commit that referenced this pull request Nov 28, 2024
adangel added a commit that referenced this pull request Nov 28, 2024
Merge pull request #5300 from adangel:pmd7-bug-fix-verification
@adangel adangel deleted the pmd7-bug-fix-verification branch November 28, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants