Under PMD 7.0.0 there is no report for the code:
public class NotSoImmutableField {
private int foo = 2;
NotSoImmutableField() {
}
NotSoImmutableField(final int foo) {
this.foo = foo;
}
public int getFoo() {
return foo;
}
}The field is never written more than once within a given constructor, nor depends on the previous value. Therefore, the code can effectively be rewritten to make foo immutable, as it's never written after initialization, for instance, the code could be rewritten as:
public class NotSoImmutableField {
private final int foo;
NotSoImmutableField() {
this(2);
}
NotSoImmutableField(final int foo) {
this.foo = foo;
}
public int getFoo() {
return foo;
}
}Originally posted by @jsotuyod in #4046 (comment)
Under PMD 7.0.0 there is no report for the code:
The field is never written more than once within a given constructor, nor depends on the previous value. Therefore, the code can effectively be rewritten to make
fooimmutable, as it's never written after initialization, for instance, the code could be rewritten as:Originally posted by @jsotuyod in #4046 (comment)