Remove deprecated gsplatCustomizeVS shader chunk#8422
Merged
Conversation
willeastcott
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gsplatCustomizeVSshader chunk and its backward compatibility layermodifyCenter,modifyCovariance,modifyColor) in favor of the newer scale-basedgsplatModifyVSAPI (modifySplatCenter,modifySplatRotationScale,modifySplatColor)gsplatExtractSize,gsplatApplyUniformScale,gsplatMakeRound)gsplatCustomizeVShas been removedrelated to #8246
Technical Details
The old customization API worked with covariance matrices (covA, covB), while the new API works directly with rotation quaternions and scale vectors, providing better performance and a simpler interface.
Migration Guide
modifyCenter(center)modifySplatCenter(center)modifyCovariance(orig, mod, covA, covB)modifySplatRotationScale(orig, mod, rotation, scale)modifyColor(center, color)modifySplatColor(center, color)gsplatExtractSize(covA, covB)gsplatGetSizeFromScale(scale)gsplatMakeRound(covA, covB, size)gsplatMakeSpherical(scale, size)gsplatApplyUniformScale(covA, covB, s)scale *= sFiles Changed
src/scene/shader-lib/glsl/chunks/gsplat/vert/gsplatCustomize.jssrc/scene/shader-lib/wgsl/chunks/gsplat/vert/gsplatCustomize.jsgsplatCommon.jsto remove includegsplat.jsandgsplatCorner.jsto remove old API callsgsplatHelpers.jsto remove covariance helperssystem.jsvalidation to report "removed"removedChunksinchunk-validation.js