Add gsplatModifyVS shader customization chunk for gaussian splats#8246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add gsplatModifyVS shader customization chunk
Adds a new shader customization API for Gaussian splats that works directly with rotation and scale instead of covariance, providing better performance and a simpler API. This is non-breaking change, and the existing chunk override functions (with a deprecated warning)
New Features
New
gsplatModifyVSshader chunk with three hook functions:modifySplatCenter(inout vec3 center)- modify splat positionmodifySplatRotationScale(vec3 originalCenter, vec3 modifiedCenter, inout vec4 rotation, inout vec3 scale)- modify rotation quaternion and scalemodifySplatColor(vec3 center, inout vec4 color)- modify splat colorNew helper functions in
gsplatHelpers:gsplatMakeSpherical(inout vec3 scale, float size)- make splat spherical by setting uniform scalegsplatGetSizeFromScale(vec3 scale)- get RMS size from scale vectorShader chunk validation system via
ShaderChunks.registerValidation():The old
gsplatCustomizeVSchunk remains functional but is deprecated. A warning is logged when it's overridden. To migrate:modifyCenter(center)modifySplatCenter(center)modifyCovariance(orig, mod, covA, covB)modifySplatRotationScale(orig, mod, rotation, scale)modifyColor(center, color)modifySplatColor(center, color)gsplatExtractSize(covA, covB)gsplatGetSizeFromScale(scale)gsplatMakeRound(covA, covB, size)gsplatMakeSpherical(scale, size)gsplatApplyUniformScale(covA, covB, s)scale *= sgsplatMakeRound(covA, covB, 0.0)scale = vec3(0.0)Updated Examples / Scripts
multi-splat.example.mjs- uses newgsplatModifyVSreveal-radial.mjsreveal-rain.mjsreveal-grid-eruption.mjsshader-effect-box.mjsshader-effect-crop.mjs