Skip to content

feat(linter): enhance const-comparisons for more cases#7628

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-03-feat_linter_enhance_const-comparisons_for_more_cases
Dec 4, 2024
Merged

feat(linter): enhance const-comparisons for more cases#7628
graphite-app[bot] merged 1 commit intomainfrom
c/12-03-feat_linter_enhance_const-comparisons_for_more_cases

Conversation

@camc314
Copy link
Copy Markdown
Contributor

@camc314 camc314 commented Dec 3, 2024

No description provided.

@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Dec 3, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Copy Markdown
Contributor Author

camc314 commented Dec 3, 2024

@github-actions github-actions Bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Dec 3, 2024
@camc314 camc314 marked this pull request as ready for review December 3, 2024 22:58
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Dec 3, 2024

CodSpeed Performance Report

Merging #7628 will not alter performance

Comparing c/12-03-feat_linter_enhance_const-comparisons_for_more_cases (afe1e9b) with main (3b1e63e)

Summary

✅ 29 untouched benchmarks

@camc314 camc314 force-pushed the c/12-03-feat_linter_enhance_const-comparisons_for_more_cases branch from 6e5fb25 to e0caeea Compare December 3, 2024 23:06
@camc314
Copy link
Copy Markdown
Contributor Author

camc314 commented Dec 3, 2024

ecosystem CI: https://github.com/oxc-project/oxlint-ecosystem-ci/actions/runs/12150048897/job/33882055967
looks good - caught an issue in napi-rs

@graphite-app graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label Dec 4, 2024
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Dec 4, 2024

Merge activity

@Boshen Boshen force-pushed the c/12-03-refactor_linter_use_get_inner_expression_in_const-comparisons_ branch from c51180e to 7ae5e26 Compare December 4, 2024 02:05
@Boshen Boshen force-pushed the c/12-03-feat_linter_enhance_const-comparisons_for_more_cases branch from e0caeea to 1ebc96c Compare December 4, 2024 02:06
@Boshen Boshen force-pushed the c/12-03-refactor_linter_use_get_inner_expression_in_const-comparisons_ branch from 7ae5e26 to c9baa09 Compare December 4, 2024 02:08
@Boshen Boshen force-pushed the c/12-03-feat_linter_enhance_const-comparisons_for_more_cases branch from 1ebc96c to 052ff9b Compare December 4, 2024 02:09
@Boshen Boshen force-pushed the c/12-03-refactor_linter_use_get_inner_expression_in_const-comparisons_ branch from c9baa09 to 0c313fc Compare December 4, 2024 02:16
@Boshen Boshen force-pushed the c/12-03-feat_linter_enhance_const-comparisons_for_more_cases branch from 052ff9b to 66e243e Compare December 4, 2024 02:17
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Dec 4, 2024
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Dec 4, 2024
@Boshen Boshen force-pushed the c/12-03-refactor_linter_use_get_inner_expression_in_const-comparisons_ branch from 0c313fc to b445654 Compare December 4, 2024 03:00
@Boshen Boshen force-pushed the c/12-03-feat_linter_enhance_const-comparisons_for_more_cases branch from 66e243e to afe1e9b Compare December 4, 2024 03:00
Base automatically changed from c/12-03-refactor_linter_use_get_inner_expression_in_const-comparisons_ to main December 4, 2024 03:06
@graphite-app graphite-app Bot merged commit afe1e9b into main Dec 4, 2024
@graphite-app graphite-app Bot deleted the c/12-03-feat_linter_enhance_const-comparisons_for_more_cases branch December 4, 2024 03:09
@oxc-bot oxc-bot mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants