Skip to content

refactor(linter): use get_inner_expression in const-comparisons#7627

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-03-refactor_linter_use_get_inner_expression_in_const-comparisons_
Dec 4, 2024
Merged

refactor(linter): use get_inner_expression in const-comparisons#7627
graphite-app[bot] merged 1 commit intomainfrom
c/12-03-refactor_linter_use_get_inner_expression_in_const-comparisons_

Conversation

@camc314
Copy link
Copy Markdown
Contributor

@camc314 camc314 commented Dec 3, 2024

No description provided.

@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Dec 3, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions Bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 3, 2024
@camc314 Graphite App
Copy link
Copy Markdown
Contributor Author

camc314 commented Dec 3, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 mentioned this pull request Dec 3, 2024
Merged
@camc314 camc314 marked this pull request as ready for review December 3, 2024 22:58
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Dec 3, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #7627 will create unknown performance changes

Comparing c/12-03-refactor_linter_use_get_inner_expression_in_const-comparisons_ (b445654) with main (3b1e63e)

Summary

🆕 29 new benchmarks

Benchmarks breakdown

Benchmark main c/12-03-refactor_linter_use_get_inner_expression_in_const-comparisons_ Change
🆕 codegen[checker.ts] N/A 25.4 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 76.9 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 730.4 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 24 µs N/A
🆕 lexer[antd.js] N/A 22.3 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.5 ms N/A
🆕 lexer[checker.ts] N/A 13.2 ms N/A
🆕 lexer[pdf.mjs] N/A 3.6 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.5 ms N/A
🆕 linter[cal.com.tsx] N/A 1.1 s N/A
🆕 linter[checker.ts] N/A 2.6 s N/A
🆕 minifier[antd.js] N/A 221.7 ms N/A
🆕 minifier[react.development.js] N/A 2.1 ms N/A
🆕 minifier[typescript.js] N/A 381.8 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 87.7 µs N/A
🆕 parser[antd.js] N/A 107.4 ms N/A
🆕 parser[cal.com.tsx] N/A 29.6 ms N/A
🆕 parser[checker.ts] N/A 54.2 ms N/A
🆕 parser[pdf.mjs] N/A 17.6 ms N/A
🆕 semantic[RadixUIAdoptionSection.jsx] N/A 74.2 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@camc314 camc314 mentioned this pull request Dec 3, 2024
Merged
@graphite-app graphite-app Bot added the 0-merge Merge with Graphite Merge Queue label Dec 4, 2024
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Dec 4, 2024 •
edited
Loading

Merge activity

Boshen pushed a commit that referenced this pull request Dec 4, 2024
@camc314
refactor(linter): use get_inner_expression in const-comparisons (#…
7ae5e26 
…7627)
@Boshen Boshen force-pushed the c/12-03-refactor_linter_use_get_inner_expression_in_const-comparisons_ branch from c51180e to 7ae5e26 Compare December 4, 2024 02:05
Boshen pushed a commit that referenced this pull request Dec 4, 2024
@camc314
refactor(linter): use get_inner_expression in const-comparisons (#…
c9baa09 
…7627)
@Boshen Boshen force-pushed the c/12-03-refactor_linter_use_get_inner_expression_in_const-comparisons_ branch from 7ae5e26 to c9baa09 Compare December 4, 2024 02:08
Boshen pushed a commit that referenced this pull request Dec 4, 2024
@camc314
refactor(linter): use get_inner_expression in const-comparisons (#…
0c313fc 
…7627)
@Boshen Boshen force-pushed the c/12-03-refactor_linter_use_get_inner_expression_in_const-comparisons_ branch from c9baa09 to 0c313fc Compare December 4, 2024 02:16
@graphite-app graphite-app Bot removed the 0-merge Merge with Graphite Merge Queue label Dec 4, 2024
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Dec 4, 2024
@Boshen Boshen force-pushed the c/12-03-refactor_linter_use_get_inner_expression_in_const-comparisons_ branch from 0c313fc to b445654 Compare December 4, 2024 03:00
@graphite-app graphite-app Bot merged commit b445654 into main Dec 4, 2024
@graphite-app graphite-app Bot deleted the c/12-03-refactor_linter_use_get_inner_expression_in_const-comparisons_ branch December 4, 2024 03:06
@oxc-bot oxc-bot mentioned this pull request Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@camc314 @Boshen