refactor(linter): remove CliRunResult from TsGoLintState (#13119)

Sysix · Sysix · commit cc2a85b0db29 · 2025-08-15T14:21:16.000+02:00
Goal is there are no references for `oxlint` functions.
Now move `TsGoLintState` to `oxc_linter` so the server can use it too 🥳
diff --git a/apps/oxlint/src/lint.rs b/apps/oxlint/src/lint.rs
@@ -304,13 +304,13 @@ impl LintRunner {
 
         // Run type-aware linting through tsgolint
         // TODO: Add a warning message if `tsgolint` cannot be found, but type-aware rules are enabled
-        if let Some(ret) = self
-            .options
-            .type_aware
-            .then(|| TsGoLintState::new(config_store.clone(), &paths, &options))
-            .and_then(|s| s.lint(tx_error.clone(), stdout))
-        {
-            return ret;
+        if self.options.type_aware {
+            if let Err(err) =
+                TsGoLintState::new(config_store.clone(), &paths, &options).lint(tx_error.clone())
+            {
+                print_and_flush_stdout(stdout, &err);
+                return CliRunResult::TsGoLintError;
+            }
         }
 
         let linter = Linter::new(LintOptions::default(), config_store, self.external_linter)
diff --git a/apps/oxlint/src/tsgolint.rs b/apps/oxlint/src/tsgolint.rs
@@ -14,10 +14,6 @@ use oxc_linter::{
 };
 use oxc_span::{SourceType, Span};
 
-use crate::cli::CliRunResult;
-
-use super::lint::print_and_flush_stdout;
-
 /// State required to initialize the `tsgolint` linter.
 #[derive(Debug, Clone)]
 pub struct TsGoLintState<'a> {
@@ -46,13 +42,9 @@ impl<'a> TsGoLintState<'a> {
         }
     }
 
-    pub fn lint(
-        self,
-        error_sender: DiagnosticSender,
-        stdout: &mut dyn Write,
-    ) -> Option<CliRunResult> {
+    pub fn lint(self, error_sender: DiagnosticSender) -> Result<(), String> {
         if self.paths.is_empty() {
-            return None;
+            return Ok(());
         }
 
         let mut resolved_configs: FxHashMap<PathBuf, ResolvedLinterState> = FxHashMap::default();
@@ -211,16 +203,10 @@ impl<'a> TsGoLintState<'a> {
         match handler.join() {
             Ok(Ok(())) => {
                 // Successfully ran tsgolint
-                None
-            }
-            Ok(Err(err)) => {
-                print_and_flush_stdout(stdout, &format!("Error running tsgolint: {err:?}"));
-                Some(CliRunResult::TsGoLintError)
-            }
-            Err(err) => {
-                print_and_flush_stdout(stdout, &format!("Error running tsgolint: {err:?}"));
-                Some(CliRunResult::TsGoLintError)
+                Ok(())
             }
+            Ok(Err(err)) => Err(format!("Error running tsgolint: {err:?}")),
+            Err(err) => Err(format!("Error running tsgolint: {err:?}")),
         }
     }
 
