refactor(linter): remove CliRunResult from TsGoLintState#13119
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 15, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
b7c6756 to
7fcd4d6
Compare
17e2219 to
59d4dc6
Compare
camc314
approved these changes
Aug 15, 2025
Contributor
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Aug 15, 2025
Goal is there are no references for `oxlint` functions. Now move `TsGoLintState` to `oxc_linter` so the server can use it too 🥳
59d4dc6 to
28628a5
Compare
Goal is there are no references for `oxlint` functions. Now move `TsGoLintState` to `oxc_linter` so the server can use it too 🥳
28628a5 to
cc2a85b
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the TsGoLintState by removing its dependency on CliRunResult and simplifying its error handling. The goal is to eliminate references to oxlint functions so that TsGoLintState can be moved to oxc_linter for broader use.
- Simplified
TsGoLintState::lintmethod to returnResult<(), String>instead ofOption<CliRunResult> - Moved error handling and stdout printing responsibility from
TsGoLintStateto the caller inLintRunner - Removed imports for
CliRunResultandprint_and_flush_stdoutfrom the tsgolint module
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/oxlint/src/tsgolint.rs | Simplified lint method signature and error handling, removed CLI-specific dependencies |
| apps/oxlint/src/lint.rs | Updated caller to handle error printing and return appropriate CliRunResult |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal is there are no references for
oxlintfunctions.Now move
TsGoLintStatetooxc_linterso the server can use it too 🥳