feat(linter): allow namespace re-export in import/no-cycle (#11995)

Boshen · Boshen · commit 899b8b4d7865 · 2025-07-01T09:52:42.000Z
Re-exporting as a namespace has no workarounds so should be allowed: In test.js: ```js export function Foo() {} export * as Example from './test.js'; ``` But, re-exporting it-self should be disallowed: ```js export function Foo() {} export * from './test.js'; ``` fixes #11646 closes #11671
diff --git a/crates/oxc_linter/src/module_record.rs b/crates/oxc_linter/src/module_record.rs
@@ -385,6 +385,11 @@ impl ExportExportName {
         matches!(self, Self::Null)
     }
 
+    /// Returns `true` if this is [`ExportExportName::Name`].
+    pub fn is_name(&self) -> bool {
+        matches!(self, Self::Name(_))
+    }
+
     /// Attempt to get the [`Span`] of this export name.
     pub fn span(&self) -> Option<Span> {
         match self {
diff --git a/crates/oxc_linter/src/rules/import/no_cycle.rs b/crates/oxc_linter/src/rules/import/no_cycle.rs
@@ -162,6 +162,24 @@ impl Rule for NoCycle {
                     }
                 }
 
+                // Allow self referencing named export.
+                // In test.js:
+                // ```
+                // export function example1() { }
+                // export * as Example from './test.js';
+                // ```
+                if path == &parent.resolved_absolute_path {
+                    if let Some(e) = val
+                        .indirect_export_entries
+                        .iter()
+                        .find(|e| e.module_request.as_ref().is_some_and(|r| r.name.as_str() == key))
+                    {
+                        if e.export_name.is_name() {
+                            return false;
+                        }
+                    }
+                }
+
                 true
             })
             .event(|event, (key, val), _| match event {
@@ -271,6 +289,7 @@ fn test() {
         // (r#"import { bar } from "./flow-types-only-importing-multiple-types""#, None),
         // (r#"import { bar } from "./flow-typeof""#, None),
         (r#"import { foo } from "./typescript/ts-types-re-exporting-type";"#, None),
+        (r"export function Foo() {}; export * as ns from './depth-zero'", None),
     ];
 
     let fail = vec![
@@ -379,6 +398,7 @@ fn test() {
             r#"import { foo } from "./typescript/ts-types-re-exporting-type";"#,
             Some(json!([{"ignoreTypes":false}])),
         ),
+        (r"export function Foo() {}; export * from './depth-zero'", None),
     ];
 
     Tester::new(NoCycle::NAME, NoCycle::PLUGIN, pass, fail)
diff --git a/crates/oxc_linter/src/snapshots/import_no_cycle.snap b/crates/oxc_linter/src/snapshots/import_no_cycle.snap
@@ -279,3 +279,11 @@ source: crates/oxc_linter/src/tester.rs
   help: These paths form a cycle:
         -> ./typescript/ts-types-re-exporting-type - fixtures/import/cycles/typescript/ts-types-re-exporting-type.ts
         -> ../depth-zero - fixtures/import/cycles/depth-zero.js
+
+  ⚠ eslint-plugin-import(no-cycle): Dependency cycle detected
+   ╭─[cycles/depth-zero.js:1:41]
+ 1 │ export function Foo() {}; export * from './depth-zero'
+   ·                                         ──────────────
+   ╰────
+  help: These paths form a cycle:
+        -> ./depth-zero - fixtures/import/cycles/depth-zero.js
