Skip to content

fix(linter): false positive in import/no-cycle#11671

Closed
camc314 wants to merge 1 commit intomainfrom
c/06-13-fix_linter_false_positive_in_import_no-cycle
Closed

fix(linter): false positive in import/no-cycle#11671
camc314 wants to merge 1 commit intomainfrom
c/06-13-fix_linter_false_positive_in_import_no-cycle

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Jun 13, 2025 •
edited
Loading

fixes #11646

@camc314 camc314 marked this pull request as ready for review June 13, 2025 11:11
@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Jun 13, 2025
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Jun 13, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 13, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #11671 will not alter performance

Comparing c/06-13-fix_linter_false_positive_in_import_no-cycle (ed8b89b) with main (094b81c)

Summary

✅ 38 untouched benchmarks

@camc314 camc314 marked this pull request as draft June 13, 2025 11:23
@camc314 camc314 force-pushed the c/06-13-fix_linter_false_positive_in_import_no-cycle branch from 3a517f5 to 90ccc18 Compare June 13, 2025 11:25
@camc314 camc314 force-pushed the c/06-13-fix_linter_false_positive_in_import_no-cycle branch from 90ccc18 to ed8b89b Compare June 13, 2025 11:43
@camc314 camc314 requested a review from Boshen June 13, 2025 11:43
@camc314 camc314 marked this pull request as ready for review June 13, 2025 11:43
@Boshen Boshen self-assigned this Jun 13, 2025
Boshen added a commit that referenced this pull request Jul 1, 2025
@Boshen
feat(linter): allow namespace re-export in import/no-cycle
8e1f026 
Re-exporting as a namespace has no workarounds so should be allowed:

In test.js:
```js
export function Foo() {}
export * as Example from './test.js';
```

But, re-exporting it-self should be disallowed:

```js
export function Foo() {}
export * from './test.js';
```

fixes #11646
closes #11671
@Boshen Boshen mentioned this pull request Jul 1, 2025
Merged
@graphite-app graphite-app bot closed this in 899b8b4 Jul 1, 2025
@camc314 camc314 deleted the c/06-13-fix_linter_false_positive_in_import_no-cycle branch July 1, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Boshen Boshen Awaiting requested review from Boshen

Assignees

@Boshen Boshen

Labels

A-linter Area - Linter C-bug Category - Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

linter: import/no-cycle false positive

2 participants

@camc314 @Boshen