Skip to content

Bump Golang version in ansible-operator images to 1.19#6398

Merged
everettraven merged 1 commit into
operator-framework:masterfrom
pit1sIBM:bump-image-go-ver
May 30, 2023
Merged

Bump Golang version in ansible-operator images to 1.19#6398
everettraven merged 1 commit into
operator-framework:masterfrom
pit1sIBM:bump-image-go-ver

Conversation

@pit1sIBM

Copy link
Copy Markdown
Contributor

Project uses 1.19 when building locally but still use 1.18 for images pushed to Quay

Resolves #6397

Description of the change:
Bumps the golang base image from 1.18 to 1.19 to align with local builds

Motivation for the change:
#6397

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Project uses 1.19 when building locally but still use 1.18 for images
pushed to Quay

Resolves operator-framework#6397

Signed-off-by: Zac Pitones <zac.pitones@ibm.com>
@pit1sIBM

Copy link
Copy Markdown
Contributor Author

Didn't update docs as I see there's an open PR for this already: #6386

@OchiengEd OchiengEd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@oceanc80 oceanc80 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good to me!

@everettraven everettraven left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2023
@pit1sIBM

Copy link
Copy Markdown
Contributor Author

@everettraven do we need to close/reopen this PR as well (#6386 (comment))? The checks appear to be stuck?

@everettraven

Copy link
Copy Markdown
Contributor

@pit1sIBM Maybe? Will try now

@everettraven everettraven reopened this May 25, 2023
@everettraven everettraven temporarily deployed to deploy May 25, 2023 16:49 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy May 25, 2023 16:49 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy May 25, 2023 16:49 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy May 25, 2023 16:49 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy May 25, 2023 16:49 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy May 25, 2023 16:49 — with GitHub Actions Inactive
@everettraven everettraven temporarily deployed to deploy May 25, 2023 16:49 — with GitHub Actions Inactive
@everettraven everettraven merged commit 24d3812 into operator-framework:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

go version in images doesn't match local builds

4 participants