Skip to content

Bumped the Golang version to 1.19 in pre-requisite documentation#6386

Merged
everettraven merged 2 commits into
operator-framework:masterfrom
ukumar009:6385
May 30, 2023
Merged

Bumped the Golang version to 1.19 in pre-requisite documentation#6386
everettraven merged 2 commits into
operator-framework:masterfrom
ukumar009:6385

Conversation

@ukumar009

Copy link
Copy Markdown
Contributor

Description of the change:
Go.mod is using golang 1.19 and pre-requisite is using 1.18. So Incrementing the developer guide to meet the golang version.

Bumped the Golang version.

Motivation for the change:
#6385

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Closes #6385

@varshaprasad96 varshaprasad96 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @UdayKumar-Ch!

This probably doesn't need a changelog, but its fine having it there!

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2023
@ukumar009

Copy link
Copy Markdown
Contributor Author

you're welcome @varshaprasad96

@everettraven

Copy link
Copy Markdown
Contributor

Closing and reopening this PR to pick up CI fixes

@everettraven everettraven left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@everettraven

Copy link
Copy Markdown
Contributor

@ukumar009 Looks like the DCO check is failing. Once that is fixed we can merge this PR in. You should be able to follow the steps given in https://github.com/operator-framework/operator-sdk/pull/6386/checks?check_run_id=12461023493 to resolve this failure

ukumar009 added 2 commits May 25, 2023 00:27
Go.mod is using golang 1.19 and pre-requisite is using 1.18. So Incrementing the developer guide to meet the golang version.

Signed-off-by: Uday Kumar <udaykumar9@proton.me>
Signed-off-by: Uday Kumar <udaykumar9@proton.me>
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label May 24, 2023
@openshift-ci

openshift-ci Bot commented May 24, 2023

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@ukumar009

Copy link
Copy Markdown
Contributor Author

@ukumar009 Looks like the DCO check is failing. Once that is fixed we can merge this PR in. You should be able to follow the steps given in https://github.com/operator-framework/operator-sdk/pull/6386/checks?check_run_id=12461023493 to resolve this failure

Thank you @everettraven I fixed the DCO issue now.

@everettraven

Copy link
Copy Markdown
Contributor

Overriding the docs link checker failures as I was able to access all the "failed" links. Merging.

@everettraven everettraven merged commit 46c8c4e into operator-framework:master May 30, 2023
@ukumar009 ukumar009 deleted the 6385 branch May 31, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wrong minimum version of go listed in prereqs in developer-guide

3 participants