Detect JUnit version in PowerMockitoMockStaticToMockito#919
Merged
Conversation
Reproduces moderneinc/customer-requests#1925: when a test class uses JUnit 4 (@org.junit.Test), ReplacePowerMockito should use @Before/@after instead of @BeforeEach/@AfterEach.
When a test class uses JUnit 4 (@org.junit.Test), the recipe now uses @Before/@after from org.junit instead of always defaulting to @BeforeEach/@AfterEach from JUnit Jupiter. Fixes moderneinc/customer-requests#1925
timtebeek
approved these changes
Feb 27, 2026
mergify bot
added a commit
to robfrank/linklift
that referenced
this pull request
Mar 10, 2026
…rom 3.28.0 to 3.29.0 [skip ci] Bumps [org.openrewrite.recipe:rewrite-testing-frameworks](https://github.com/openrewrite/rewrite-testing-frameworks) from 3.28.0 to 3.29.0. Release notes *Sourced from [org.openrewrite.recipe:rewrite-testing-frameworks's releases](https://github.com/openrewrite/rewrite-testing-frameworks/releases).* > 3.29.0 > ------ > > What's Changed > -------------- > > * Detect JUnit version in PowerMockitoMockStaticToMockito by [`@MBoegers`](https://github.com/MBoegers) in [openrewrite/rewrite-testing-frameworks#919](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/919) > * ReplacePowerMockito: ensure mockito-core is added when PowerMock is removed by [`@MBoegers`](https://github.com/MBoegers) in [openrewrite/rewrite-testing-frameworks#920](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/920) > * Remove all remaining PowerMock dependencies in ReplacePowerMockito recipe by [`@steve-aom-elliott`](https://github.com/steve-aom-elliott) in [openrewrite/rewrite-testing-frameworks#921](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/921) > * Add JUnit 4 support to AddMockitoExtensionIfAnnotationsUsed by [`@bmuschko`](https://github.com/bmuschko) in [openrewrite/rewrite-testing-frameworks#922](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/922) > * Use mockito-inline instead of mockito-core where applicable by [`@bmuschko`](https://github.com/bmuschko) in [openrewrite/rewrite-testing-frameworks#923](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/923) > * Add recipe to replace MockitoTestExecutionListener by [`@steve-aom-elliott`](https://github.com/steve-aom-elliott) in [openrewrite/rewrite-testing-frameworks#924](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/924) > * Remove empty constructors and suite() methods in MigrateJUnitTestCase by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-testing-frameworks#926](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/926) > > New Contributors > ---------------- > > * [`@bmuschko`](https://github.com/bmuschko) made their first contribution in [openrewrite/rewrite-testing-frameworks#922](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/922) > > **Full Changelog**: <openrewrite/rewrite-testing-frameworks@v3.28.0...v3.29.0> Commits * [`7796693`](openrewrite/rewrite-testing-frameworks@7796693) Remove empty constructors and suite() methods in MigrateJUnitTestCase ([#926](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/issues/926)) * [`5c07d95`](openrewrite/rewrite-testing-frameworks@5c07d95) Add recipe to replace MockitoTestExecutionListener ([#924](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/issues/924)) * [`f1b202d`](openrewrite/rewrite-testing-frameworks@f1b202d) Use mockito-inline instead of mockito-core where applicable ([#923](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/issues/923)) * [`63820f4`](openrewrite/rewrite-testing-frameworks@63820f4) Add JUnit 4 support to AddMockitoExtensionIfAnnotationsUsed ([#1932](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/issues/1932)) ([#922](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/issues/922)) * [`e8bbdf0`](openrewrite/rewrite-testing-frameworks@e8bbdf0) Remove all remaining PowerMock dependencies in ReplacePowerMockito recipe ([#921](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/issues/921)) * [`0e3d076`](openrewrite/rewrite-testing-frameworks@0e3d076) ReplacePowerMockito: ensure mockito-core is added when PowerMock is removed (... * [`af19fad`](openrewrite/rewrite-testing-frameworks@af19fad) Detect JUnit version in PowerMockitoMockStaticToMockito ([#919](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/issues/919)) * See full diff in [compare view](openrewrite/rewrite-testing-frameworks@v3.28.0...v3.29.0) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PowerMockitoMockStaticToMockitonow detects the JUnit version and uses@Before/@Afterfromorg.junitfor JUnit 4 projects instead of always defaulting to@BeforeEach/@AfterEachfrom JUnit JupiterFixes the three-way detection: TestNG →
@BeforeMethod/@AfterMethod, JUnit 4 →@Before/@After, Jupiter →@BeforeEach/@AfterEachAlso resets
tearDownMethodAnnotationParametersin non-TestNG branches to prevent stale state if the visitor processes a TestNG file before a JUnit fileFixes moderneinc/customer-requests#1925
Test plan
junit4PrepareForTestUsesBeforeAndAftertest confirming JUnit 4 input produces@Before/@AftershouldNotDuplicateVarsAndMethodswhich had JUnit 4 input but expected Jupiter output (the bug)PowerMockitoMockStaticToMockitoTesttests passReplacePowerMockitoIntegrationTestintegration tests pass