Skip to content

Add test for Kotlin#876

Merged
timtebeek merged 2 commits intomainfrom
check-kotlin
Dec 16, 2025
Merged

Add test for Kotlin#876
timtebeek merged 2 commits intomainfrom
check-kotlin

Conversation

@Laurens-W
Copy link
Copy Markdown
Contributor

What's changed?

Added Kotlin based tests to validate these recipes work

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@Laurens-W Laurens-W requested a review from timtebeek December 16, 2025 14:10
@Laurens-W Laurens-W self-assigned this Dec 16, 2025
@Laurens-W Laurens-W added the bug Something isn't working label Dec 16, 2025
@github-project-automation github-project-automation bot moved this to In Progress in OpenRewrite Dec 16, 2025
@Laurens-W Laurens-W marked this pull request as ready for review December 16, 2025 14:41
Copy link
Copy Markdown
Member

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Should be good to have especially when we swap Kotlin v1 for v2.

@github-project-automation github-project-automation bot moved this from In Progress to Ready to Review in OpenRewrite Dec 16, 2025
@timtebeek timtebeek merged commit 5459e88 into main Dec 16, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite Dec 16, 2025
@timtebeek timtebeek deleted the check-kotlin branch December 16, 2025 15:05
mergify bot added a commit to robfrank/linklift that referenced this pull request Dec 22, 2025
…rom 3.23.0 to 3.24.0 [skip ci]

Bumps [org.openrewrite.recipe:rewrite-testing-frameworks](https://github.com/openrewrite/rewrite-testing-frameworks) from 3.23.0 to 3.24.0.
Release notes

*Sourced from [org.openrewrite.recipe:rewrite-testing-frameworks's releases](https://github.com/openrewrite/rewrite-testing-frameworks/releases).*

> 3.24.0
> ------
>
> What's Changed
> --------------
>
> * Recipe to check that Kotlin test methods return Unit by [`@​greg-dennis`](https://github.com/greg-dennis) in [openrewrite/rewrite-testing-frameworks#871](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/871)
> * Reorder `maybeRemoveImport` before `maybeAddImport` by [`@​timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-testing-frameworks#873](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/873)
> * Add test for Kotlin by [`@​Laurens-W`](https://github.com/Laurens-W) in [openrewrite/rewrite-testing-frameworks#876](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/876)
>
> New Contributors
> ----------------
>
> * [`@​greg-dennis`](https://github.com/greg-dennis) made their first contribution in [openrewrite/rewrite-testing-frameworks#871](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/871)
>
> **Full Changelog**: <openrewrite/rewrite-testing-frameworks@v3.23.0...v3.24.0>


Commits

* [`5459e88`](openrewrite/rewrite-testing-frameworks@5459e88) Add test for Kotlin ([#876](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/issues/876))
* [`20cca13`](openrewrite/rewrite-testing-frameworks@20cca13) Only match methods with test annotations
* [`9803871`](openrewrite/rewrite-testing-frameworks@9803871) Reorder `maybeRemoveImport` before `maybeAddImport` ([#873](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/issues/873))
* [`42c22af`](openrewrite/rewrite-testing-frameworks@42c22af) Add documentation example for `KotlinTestMethodsShouldReturnUnit`
* [`f378cb5`](openrewrite/rewrite-testing-frameworks@f378cb5) Recipe to check that Kotlin test methods return Unit ([#871](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/issues/871))
* [`69f23b7`](openrewrite/rewrite-testing-frameworks@69f23b7) OpenRewrite recipe best practices
* [`76041b7`](openrewrite/rewrite-testing-frameworks@76041b7) Remove unused local variable
* [`edf6bcd`](openrewrite/rewrite-testing-frameworks@edf6bcd) Add test for Kotlin
* See full diff in [compare view](openrewrite/rewrite-testing-frameworks@v3.23.0...v3.24.0)
  
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=org.openrewrite.recipe:rewrite-testing-frameworks&package-manager=maven&previous-version=3.23.0&new-version=3.24.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants