Skip to content

Change dependencies and types for testcontainers v2#830

Merged
timtebeek merged 7 commits intoopenrewrite:mainfrom
sullis:sullis/testcontainers2
Oct 17, 2025
Merged

Change dependencies and types for testcontainers v2#830
timtebeek merged 7 commits intoopenrewrite:mainfrom
sullis:sullis/testcontainers2

Conversation

@sullis
Copy link
Copy Markdown
Contributor

@sullis sullis commented Oct 15, 2025

What's changed?

adding support for testcontainers-java 2.x

What's your motivation?

testcontainers-java 2.0.0 was released on October 14 2025

Release notes

https://github.com/testcontainers/testcontainers-java/releases/tag/2.0.0

Maven Central

https://repo1.maven.org/maven2/org/testcontainers/testcontainers-bom/2.0.0/testcontainers-bom-2.0.0.pom

https://repo1.maven.org/maven2/org/testcontainers/testcontainers-bom/1.21.3/testcontainers-bom-1.21.3.pom

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

@timtebeek
Copy link
Copy Markdown
Member

Great to see! Let me know if you need any help to finish this PR.

@sullis sullis force-pushed the sullis/testcontainers2 branch 3 times, most recently from 6ff745a to b11e854 Compare October 16, 2025 02:21
@sullis sullis marked this pull request as ready for review October 16, 2025 02:33
@sullis
Copy link
Copy Markdown
Contributor Author

sullis commented Oct 16, 2025

Please take a look @timtebeek

@timtebeek timtebeek self-requested a review October 16, 2025 05:51
@sullis sullis force-pushed the sullis/testcontainers2 branch from b11e854 to c2235e1 Compare October 17, 2025 06:10
@sullis sullis force-pushed the sullis/testcontainers2 branch from c2235e1 to 5751f9f Compare October 17, 2025 06:14
@sullis
Copy link
Copy Markdown
Contributor Author

sullis commented Oct 17, 2025

ready for review

@timtebeek timtebeek changed the title support testcontainers 2.x Change dependencies and types for testcontainers v2 Oct 17, 2025
@timtebeek timtebeek moved this from In Progress to Ready to Review in OpenRewrite Oct 17, 2025
Copy link
Copy Markdown
Member

@timtebeek timtebeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for kicking this off! I've changed your PR to use (test) classpath from resources to avoid a transitive dependency on Jackson 2.18+ that had failed the tests.

@timtebeek timtebeek merged commit d7fe158 into openrewrite:main Oct 17, 2025
1 of 2 checks passed
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in OpenRewrite Oct 17, 2025
@sullis sullis deleted the sullis/testcontainers2 branch October 19, 2025 16:53
mergify bot added a commit to robfrank/linklift that referenced this pull request Oct 30, 2025
…rom 3.19.0 to 3.20.0 [skip ci]

Bumps [org.openrewrite.recipe:rewrite-testing-frameworks](https://github.com/openrewrite/rewrite-testing-frameworks) from 3.19.0 to 3.20.0.
Release notes

*Sourced from [org.openrewrite.recipe:rewrite-testing-frameworks's releases](https://github.com/openrewrite/rewrite-testing-frameworks/releases).*

> 3.20.0
> ------
>
> What's Changed
> --------------
>
> * Change dependencies and types for testcontainers v2 by [`@​sullis`](https://github.com/sullis) in [openrewrite/rewrite-testing-frameworks#830](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/830)
> * Additional Testcontainers 2.0.x recipes by [`@​eddumelendez`](https://github.com/eddumelendez) in [openrewrite/rewrite-testing-frameworks#832](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/832)
> * Upgrade testcontainers for the JUnit 5 migration by [`@​timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-testing-frameworks#833](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/833)
>
> New Contributors
> ----------------
>
> * [`@​eddumelendez`](https://github.com/eddumelendez) made their first contribution in [openrewrite/rewrite-testing-frameworks#832](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/pull/832)
>
> **Full Changelog**: <openrewrite/rewrite-testing-frameworks@v3.19.0...v3.20.0>


Commits

* [`1a882f4`](openrewrite/rewrite-testing-frameworks@1a882f4) Upgrade testcontainers for the JUnit 5 migration ([#833](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/issues/833))
* [`be5cbb3`](openrewrite/rewrite-testing-frameworks@be5cbb3) Fix failing easymock tests
* [`f1a3fa5`](openrewrite/rewrite-testing-frameworks@f1a3fa5) Fix failing easymock tests
* [`42c3046`](openrewrite/rewrite-testing-frameworks@42c3046) Additional Testcontainers 2.0.x recipes ([#832](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/issues/832))
* [`8c1afc3`](openrewrite/rewrite-testing-frameworks@8c1afc3) Use classpathFromResources for `EasyMockToMockitoTest` which needs JUnit-4
* [`d7fe158`](openrewrite/rewrite-testing-frameworks@d7fe158) Change dependencies and types for testcontainers v2 ([#830](https://redirect.github.com/openrewrite/rewrite-testing-frameworks/issues/830))
* [`ba3685d`](openrewrite/rewrite-testing-frameworks@ba3685d) Avoid Jackson 2.19 brought in through test dependencies
* See full diff in [compare view](openrewrite/rewrite-testing-frameworks@v3.19.0...v3.20.0)
  
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=org.openrewrite.recipe:rewrite-testing-frameworks&package-manager=maven&previous-version=3.19.0&new-version=3.20.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants